chore: update tokens from figma - #8237
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (9)
WalkthroughUpdated generated timestamps and reduced many theme mixins to only declare tokens that differ from the base theme; several read-only border/background token mappings were adjusted and one default token removed. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
|
Preview: https://pf-pr-8237.surge.sh A11y report: https://pf-pr-8237-a11y.surge.sh |
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/patternfly/base/tokens/tokens-default.scss (1)
598-601:⚠️ Potential issue | 🟠 MajorKeep
--pf-t--global--text-decoration--offset--hoveravailable.
src/patternfly/components/Button/button.scssstill consumes this token at Lines 37-40, 144-147, and 289-296, andsrc/patternfly/base/patternfly-variables.scssincludesdefault.pf-v6-tokensfor every theme at Lines 17-68. Dropping it here leaves those hover/clicked underline offsets unresolved across all themes.💡 Minimal compatibility fix
--pf-t--global--text-decoration--color--default: var(--pf-t--global--border--color--300); --pf-t--global--text-decoration--offset--default: var(--pf-t--global--spacer--xs); + --pf-t--global--text-decoration--offset--hover: var(--pf-t--global--text-decoration--offset--default); --pf-t--global--text-decoration--width--default: var(--pf-t--global--border--width--regular); --pf-t--global--text-decoration--width--hover: var(--pf-t--global--border--width--strong);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/patternfly/base/tokens/tokens-default.scss` around lines 598 - 601, Restore the CSS token --pf-t--global--text-decoration--offset--hover in the tokens-default.scss token set (the value can mirror the default, e.g., var(--pf-t--global--spacer--xs)) so the Button component’s hover/click underline offset resolution works; update the tokens list to include --pf-t--global--text-decoration--offset--hover alongside --pf-t--global--text-decoration--offset--default to ensure consumers (Button) and the patternfly variables import continue to find the hover token.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@src/patternfly/base/tokens/tokens-default.scss`:
- Around line 598-601: Restore the CSS token
--pf-t--global--text-decoration--offset--hover in the tokens-default.scss token
set (the value can mirror the default, e.g., var(--pf-t--global--spacer--xs)) so
the Button component’s hover/click underline offset resolution works; update the
tokens list to include --pf-t--global--text-decoration--offset--hover alongside
--pf-t--global--text-decoration--offset--default to ensure consumers (Button)
and the patternfly variables import continue to find the hover token.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: ce073f95-4dd1-4a28-945a-a6274af048a6
📒 Files selected for processing (11)
src/patternfly/base/tokens/tokens-dark.scsssrc/patternfly/base/tokens/tokens-default.scsssrc/patternfly/base/tokens/tokens-glass-dark.scsssrc/patternfly/base/tokens/tokens-glass.scsssrc/patternfly/base/tokens/tokens-palette.scsssrc/patternfly/base/tokens/tokens-redhat-dark.scsssrc/patternfly/base/tokens/tokens-redhat-glass-dark.scsssrc/patternfly/base/tokens/tokens-redhat-glass.scsssrc/patternfly/base/tokens/tokens-redhat-highcontrast-dark.scsssrc/patternfly/base/tokens/tokens-redhat-highcontrast.scsssrc/patternfly/base/tokens/tokens-redhat.scss
Collaborator
|
🎉 This PR is included in version 6.5.0-prerelease.56 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Chores
Bug Fixes