Skip to content

fix: Updated to use unified theme token changes for dock navigation. - #8192

Closed
dlabaj wants to merge 1 commit into
patternfly:mainfrom
dlabaj:issue-8130
Closed

fix: Updated to use unified theme token changes for dock navigation.#8192
dlabaj wants to merge 1 commit into
patternfly:mainfrom
dlabaj:issue-8130

Conversation

@dlabaj

@dlabaj dlabaj commented Mar 2, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Fixes issue #8130 by applying the new unified theme token updates.

Summary by CodeRabbit

  • Style
    • Updated navigation item accents to use the brand accent color for improved visual consistency.
    • Adjusted navigation link corner radius to align with action/plain defaults, yielding subtly refined rounded corners.
    • No functional changes; visual polish only.

@dlabaj
dlabaj requested review from mcoker and srambach March 2, 2026 18:18
@dlabaj dlabaj self-assigned this Mar 2, 2026
@coderabbitai

coderabbitai Bot commented Mar 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 301696e and e8e8c18.

📒 Files selected for processing (1)
  • src/patternfly/components/Nav/nav.scss

Walkthrough

This PR updates CSS custom property tokens in the Nav component styling. The nav item accent color and nav link border radius are changed to reference different design tokens from the theme palette.

Changes

Cohort / File(s) Summary
Nav Component Styling
src/patternfly/components/Nav/nav.scss		 Updated --#{$nav}__item--accent--color from border-color-clicked token to brand-accent-default token. Updated --#{$nav}__link--BorderRadius from small border-radius to action-plain-default border-radius token. Minor formatting additions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

released on @prerelease``

Suggested reviewers

  • mcoker
  • srambach
  • kmcfaul
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title follows conventional commit format with 'fix:' prefix and clearly describes the main change of updating theme tokens for dock navigation.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
coderabbitai Bot requested a review from kmcfaul March 2, 2026 18:19
@patternfly-build

patternfly-build commented Mar 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-pr-8192.surge.sh

A11y report: https://pf-pr-8192-a11y.surge.sh

@mcoker

mcoker commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Dupe of the changes in #8193

@mcoker mcoker closed this Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srambach srambach Awaiting requested review from srambach
@mcoker mcoker Awaiting requested review from mcoker
@kmcfaul kmcfaul Awaiting requested review from kmcfaul

Assignees

@dlabaj dlabaj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dlabaj @patternfly-build @mcoker