Skip to content

fix(drawer): apply unified theme - #8190

Closed
srambach wants to merge 1 commit into
patternfly:mainfrom
srambach:3136-unified-drawer
Closed

fix(drawer): apply unified theme#8190
srambach wants to merge 1 commit into
patternfly:mainfrom
srambach:3136-unified-drawer

Conversation

@srambach

@srambach srambach commented Mar 2, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Fixes #8017
JIRA 3136

Just sets the background color to use the floating token and updates the glass token to the right name.
Pill/rounded variant and splitter changes are expected to be in follow on issues.

Summary by CodeRabbit

  • Style
    • Updated Drawer component color styling to enhance visual consistency and appearance across component variations.

@coderabbitai

coderabbitai Bot commented Mar 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 81619a5 and 12d209e.

📒 Files selected for processing (1)
  • src/patternfly/components/Drawer/drawer.scss

Walkthrough

Updates color token references in the Drawer component SCSS file. Replaces primary-default and primary-glass tokens with floating-default and glass-primary variants across three style declarations affecting section and panel background colors.

Changes

Cohort / File(s) Summary
Drawer Token Updates
src/patternfly/components/Drawer/drawer.scss		 Switched color tokens: section BackgroundColor from primary-default to floating-default, panel inline background from primary-default to glass-primary, and panel glass background from primary-glass to glass-primary.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

Possibly related PRs

Suggested labels

released on @prerelease``

Suggested reviewers

  • andrew-ronaldson
  • lboehling
  • mcoker
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(drawer): apply unified theme' follows conventional commit guidelines with proper scope and descriptive message.
Linked Issues check ✅ Passed The PR addresses the core requirement from issue #8017 to update drawer design tokens to align with the Unified Theme, updating color tokens as specified in the design.
Out of Scope Changes check ✅ Passed All changes are limited to drawer SCSS color token updates that directly support the Unified Theme alignment objective; pill variant and splitter changes are appropriately deferred.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented Mar 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-pr-8190.surge.sh

A11y report: https://pf-pr-8190-a11y.surge.sh

@srambach
srambach force-pushed the 3136-unified-drawer branch from 12d209e to 796346a Compare March 4, 2026 20:03
@mcoker

mcoker commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

closing in favor of #8207

@mcoker mcoker closed this Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrew-ronaldson andrew-ronaldson Awaiting requested review from andrew-ronaldson
@lboehling lboehling Awaiting requested review from lboehling
@mcoker mcoker Awaiting requested review from mcoker
@kaylachumley kaylachumley Awaiting requested review from kaylachumley

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drawers - update tokens and add Pill variant

4 participants

@srambach @patternfly-build @mcoker @nicolethoen