Renames colummn to column - #489
Merged
jeff-phillips-18 merged 2 commits intoJun 14, 2017
Merged
Conversation
This is a non-breaking change for when colummn is present, it will be copied to column The only thing we lose here is making column a required binding for the table component, kinda unavoidable though
jeff-phillips-18
approved these changes
Jun 14, 2017
jeff-phillips-18
left a comment
Member
There was a problem hiding this comment.
LGTM, one small comment.
|
|
||
| if (angular.isDefined(ctrl.colummns)) { | ||
| ctrl.columns = ctrl.colummns; | ||
| } |
Member
There was a problem hiding this comment.
should probably check if columns is undefined. If both are set (for some strange reason, we should use columns over columms)
Contributor
Author
There was a problem hiding this comment.
NICE 🍨 new commit 🤘
dtaylor113
approved these changes
Jun 14, 2017
Garuntees we'll only ever use columns value
Member
|
Thanks @AllenBW, can't believe that spelling error was so prevalent and I didn't see it :-) |
Contributor
Author
|
@dtaylor113 anytime!! 🙇 💃 🌮 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a non-breaking change for when colummn is present, it will be copied to column
The only thing we lose here is making column a required binding for the table component, kinda unavoidable though
closes #488