prepare_guest_template.sh fails when there are multiple xs-tools iso's in ISO_DIR#10
Closed
ramielrowe wants to merge 1 commit intoopenstack:masterfrom
Closed
prepare_guest_template.sh fails when there are multiple xs-tools iso's in ISO_DIR#10ramielrowe wants to merge 1 commit intoopenstack:masterfrom
ramielrowe wants to merge 1 commit intoopenstack:masterfrom
Conversation
…s in ISO_DIR
In the case of two iso's ('xs-tools-6.0.2.iso' and 'xs-tools-6.0.2-1111.iso'), TOOLS_ISO gets set to 'xs-tools-6.0.2-1111.iso xs-tools-6.0.2.iso' This causes 'mount -o loop xs-tools-6.0.2-1111.iso xs-tools-6.0.2.iso $TMP_DIR' to get called, which fails as it's meant to be called with only one file. This fix simply sets TOOLS_ISO to the first iso that ls returns.
Change-Id: Id4d883e2b1e33b233c9ee907016b4ce117c28021
Contributor
Author
|
Submitted to review.openstack.org. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case of two iso's ('xs-tools-6.0.2.iso' and 'xs-tools-6.0.2-1111.iso'), TOOLS_ISO gets set to 'xs-tools-6.0.2-1111.iso xs-tools-6.0.2.iso' This causes 'mount -o loop xs-tools-6.0.2-1111.iso xs-tools-6.0.2.iso $TMP_DIR' to get called, which fails as it's meant to be called with only one file. This fix simply sets TOOLS_ISO to the first iso that ls returns.