Skip to content

Improve Subsystem Health popover text flow and spacing - #2123

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
andybraren:improve-subsystem-health-popover-layout
Jul 24, 2019
Merged

Improve Subsystem Health popover text flow and spacing#2123
openshift-merge-robot merged 1 commit into
openshift:masterfrom
andybraren:improve-subsystem-health-popover-layout

Conversation

@andybraren

@andybraren andybraren commented Jul 23, 2019

Copy link
Copy Markdown
Contributor

Resolves the text wrapping problems noted in CONSOLE-1635.

Also:

  • Improves the spacing between subsystem items
  • Prevents odd-looking span wrapping behavior at certain screen sizes
  • Capitalizes "health" in "Subsystem health"
  • Removes the no-longer-needed .co-health-card__subsystem-item
  • Extends line separators to the edges of the popover

Before:

2019-07-22 22 09 02

After:

2019-07-22 21 57 11

@andybraren
Improve Subsystem Health flow and spacing
4eb967a 
Uses margin around separator for better spacing. Makes spans a block to prevent weird wrapping at certain sizes. Removes susbsytem item class. Capitalizes popover title.
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 23, 2019
@spadgett spadgett added this to the v4.2 milestone Jul 23, 2019
spadgett
spadgett approved these changes Jul 23, 2019
View reviewed changes

@spadgett spadgett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2019
@openshift-ci-robot

openshift-ci-robot commented Jul 23, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andybraren, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2019
@spadgett

spadgett commented Jul 23, 2019

Copy link
Copy Markdown
Member

/kind bug
/retest

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 23, 2019
@andybraren

andybraren commented Jul 24, 2019

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-merge-robot
openshift-merge-robot merged commit e52f208 into openshift:master Jul 24, 2019
@andybraren
andybraren deleted the improve-subsystem-health-popover-layout branch December 19, 2019 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes
@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18
@kyoto kyoto Awaiting requested review from kyoto

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v4.2

Development

Successfully merging this pull request may close these issues.

4 participants

@andybraren @openshift-ci-robot @spadgett @openshift-merge-robot