OCPBUGS-105409: chore: remove AWSServiceLBNetworkSecurityGroup feature gate by damdo · Pull Request #2974 · openshift/api

damdo · 2026-08-10T16:34:46Z

Summary

Remove the AWSServiceLBNetworkSecurityGroup feature gate from features/features.go — it has been enabled by default across all profiles and feature sets and is no longer needed
Regenerate payload feature gate manifests (8 files) to reflect the removal
Update test data in featuregate-test-analyzer_test.go to use a different AWS gate (AWSClusterHostedDNS)

Test plan

make test-unit passes (including TestOKDHasAllDefaultFeatureGates)
hack/verify-payload-featuregates.sh passes
No remaining references to AWSServiceLBNetworkSecurityGroup in the codebase

openshift-merge-bot · 2026-08-10T16:34:48Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci · 2026-08-10T16:34:50Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2026-08-10T16:34:51Z

Hello @damdo! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

coderabbitai · 2026-08-10T16:35:09Z

📝 Walkthrough

Walkthrough

Removed the AWSServiceLBNetworkSecurityGroup feature-gate declaration and feature support matrix entry. Removed the feature gate from HyperShift and self-managed HA manifests. Updated the AWS HyperShift analyzer test to use AWSClusterHostedDNS.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR changes no Ginkgo test titles; its only test change is a static feature-gate value in a standard-library t.Run table.
Test Structure And Quality	✅ Passed	The only touched test is a standard table-driven Go unit test for filterVariants; it uses a diagnostic t.Errorf and has no Ginkgo, cluster resources, cleanup, or wait operations.
Microshift Test Compatibility	✅ Passed	The pull request adds no Ginkgo e2e tests; it changes one literal in the existing standard Go Test_filterVariants unit test and adds no MicroShift-incompatible API usage.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR adds no Ginkgo e2e tests; its only added Go line changes a feature-gate string in a standard testing.T unit test.
Topology-Aware Scheduling Compatibility	✅ Passed	The patch only removes a feature-gate declaration, matrix row, and FeatureGate entries, plus test data; it adds no workload or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR changes only feature-gate metadata, manifests, and one test literal; the patch adds no main/init/suite setup or stdout/logging writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR adds no Ginkgo e2e tests. The only changed test is a standard Go Test_filterVariants unit test, and no new IPv4 or external-connectivity requirement is introduced.
No-Weak-Crypto	✅ Passed	The patch only removes feature-gate entries and changes one test string; scans found no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons in changed paths.
Container-Privileges	✅ Passed	The patch adds no privilege settings; all eight JSON manifests are FeatureGate resources, and changed files contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalat...
No-Sensitive-Data-In-Logs	✅ Passed	The PR adds only the non-sensitive feature-gate string `AWSClusterHostedDNS`; all other changes delete declarations or manifest entries, with no new logging calls or sensitive data.
Description check	✅ Passed	The description clearly explains removal of the feature gate, manifest updates, test changes, and validation steps.
Title check	✅ Passed	The title clearly and concisely describes removal of the AWSServiceLBNetworkSecurityGroup feature gate.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

damdo · 2026-08-11T08:50:46Z

/assign @mtulio @mfbonfigli

damdo · 2026-08-11T10:31:00Z

/hold

depends on openshift/cluster-cloud-controller-manager-operator#500 merging first

qodo-for-rh-openshift · 2026-08-11T10:32:29Z

PR Summary by Qodo

Remove AWSServiceLBNetworkSecurityGroup feature gate

⚙️ Configuration changes 🧪 Tests 📝 Documentation 🕐 20-40 Minutes

AI Description

• Remove redundant AWSServiceLBNetworkSecurityGroup feature gate definition
• Regenerate payload featuregate manifests to drop the removed gate
• Update featuregate analyzer test data to use an alternative AWS gate

Diagram

graph TD
  FG["features/features.go"] --> CG["featuregate codegen"] --> PM["payload-manifests/*.yaml"]
  FG --> DOC["features.md"]
  FG --> UT["featuregate-test-analyzer_test.go"]

High-Level Assessment

The following are alternative approaches to this PR:

1. Deprecate gate (keep definition, mark no-op)

➕ Avoids breaking any downstream tooling/config that still references the name
➕ Allows a staged removal with clearer upgrade messaging
➖ Keeps dead metadata and increases long-term maintenance noise
➖ Still requires eventual removal and manifest regeneration later

2. Alias to a successor gate name

➕ Preserves compatibility while steering users toward the canonical knob
➕ Can simplify migration if an equivalent gate exists
➖ Introduces ambiguity about which gate is authoritative
➖ Requires extra validation and documentation to avoid surprises

Recommendation: Proceed with full removal as implemented since the gate was already enabled by default everywhere and the PR updates generated payloads and test fixtures accordingly. The deprecation/alias options mainly help if external consumers still reference the gate; given the stated verification of no remaining references, the current approach is the simplest and cleanest.

Files changed (11) +1 / -34

Tests (1) +1 / -1

featuregate-test-analyzer_test.goSwitch AWS feature-gate test case to AWSClusterHostedDNS +1/-1

Switch AWS feature-gate test case to AWSClusterHostedDNS
• Updates the filter-variants unit test fixture to use AWSClusterHostedDNS instead of the removed AWSServiceLBNetworkSecurityGroup gate name.
tools/codegen/cmd/featuregate-test-analyzer_test.go

Documentation (1) +0 / -1

features.mdRemove AWSServiceLBNetworkSecurityGroup from feature table +0/-1

Remove AWSServiceLBNetworkSecurityGroup from feature table
• Drops the AWSServiceLBNetworkSecurityGroup row from the published feature-gate matrix to match the source-of-truth registry removal.
features.md

Other (9) +0 / -32

features.goDelete AWSServiceLBNetworkSecurityGroup gate registration +0/-8

Delete AWSServiceLBNetworkSecurityGroup gate registration
• Removes the AWSServiceLBNetworkSecurityGroup feature gate definition/registration, including its metadata (owner, component, enhancement link) and enablement sets.
features/features.go

featureGate-4-10-Hypershift-Default.yamlRemove AWSServiceLBNetworkSecurityGroup from Hypershift Default +0/-3

Remove AWSServiceLBNetworkSecurityGroup from Hypershift Default
• Regenerated payload manifest no longer lists AWSServiceLBNetworkSecurityGroup among enabled gates for the Hypershift Default variant.
payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml

featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yamlRemove AWSServiceLBNetworkSecurityGroup from Hypershift DevPreviewNoUpgrade +0/-3

Remove AWSServiceLBNetworkSecurityGroup from Hypershift DevPreviewNoUpgrade
• Regenerated payload manifest no longer lists AWSServiceLBNetworkSecurityGroup among enabled gates for the Hypershift DevPreviewNoUpgrade variant.
payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml

featureGate-4-10-Hypershift-OKD.yamlRemove AWSServiceLBNetworkSecurityGroup from Hypershift OKD +0/-3

Remove AWSServiceLBNetworkSecurityGroup from Hypershift OKD
• Regenerated payload manifest no longer lists AWSServiceLBNetworkSecurityGroup among enabled gates for the Hypershift OKD variant.
payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml

featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yamlRemove AWSServiceLBNetworkSecurityGroup from Hypershift TechPreviewNoUpgrade +0/-3

Remove AWSServiceLBNetworkSecurityGroup from Hypershift TechPreviewNoUpgrade
• Regenerated payload manifest no longer lists AWSServiceLBNetworkSecurityGroup among enabled gates for the Hypershift TechPreviewNoUpgrade variant.
payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml

featureGate-4-10-SelfManagedHA-Default.yamlRemove AWSServiceLBNetworkSecurityGroup from SelfManagedHA Default +0/-3

Remove AWSServiceLBNetworkSecurityGroup from SelfManagedHA Default
• Regenerated payload manifest no longer lists AWSServiceLBNetworkSecurityGroup among enabled gates for the SelfManagedHA Default variant.
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml

featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yamlRemove AWSServiceLBNetworkSecurityGroup from SelfManagedHA DevPreviewNoUpgrade +0/-3

Remove AWSServiceLBNetworkSecurityGroup from SelfManagedHA DevPreviewNoUpgrade
• Regenerated payload manifest no longer lists AWSServiceLBNetworkSecurityGroup among enabled gates for the SelfManagedHA DevPreviewNoUpgrade variant.
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml

featureGate-4-10-SelfManagedHA-OKD.yamlRemove AWSServiceLBNetworkSecurityGroup from SelfManagedHA OKD +0/-3

Remove AWSServiceLBNetworkSecurityGroup from SelfManagedHA OKD
• Regenerated payload manifest no longer lists AWSServiceLBNetworkSecurityGroup among enabled gates for the SelfManagedHA OKD variant.
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yamlRemove AWSServiceLBNetworkSecurityGroup from SelfManagedHA TechPreviewNoUpgrade +0/-3

Remove AWSServiceLBNetworkSecurityGroup from SelfManagedHA TechPreviewNoUpgrade
• Regenerated payload manifest no longer lists AWSServiceLBNetworkSecurityGroup among enabled gates for the SelfManagedHA TechPreviewNoUpgrade variant.
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml

qodo-for-rh-openshift · 2026-08-11T10:34:26Z

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can group findings by type and pick your Finding display, from Minimal to Full

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

damdo · 2026-08-11T12:27:32Z

/retest

mfbonfigli · 2026-08-11T16:12:15Z

/lgtm

openshift-merge-bot · 2026-08-11T16:12:31Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

The AWSServiceLBNetworkSecurityGroup feature gate has been enabled by default across all profiles and feature sets, making it redundant. Remove the gate definition and regenerate payload manifests.

openshift-ci-robot · 2026-08-11T19:09:28Z

@damdo: This pull request references Jira Issue OCPBUGS-105409, which is invalid:

expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Remove the AWSServiceLBNetworkSecurityGroup feature gate from features/features.go — it has been enabled by default across all profiles and feature sets and is no longer needed

Regenerate payload feature gate manifests (8 files) to reflect the removal

Update test data in featuregate-test-analyzer_test.go to use a different AWS gate (AWSClusterHostedDNS)

Test plan

make test-unit passes (including TestOKDHasAllDefaultFeatureGates)

hack/verify-payload-featuregates.sh passes

No remaining references to AWSServiceLBNetworkSecurityGroup in the codebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

damdo · 2026-08-11T19:24:29Z

/pipeline auto

openshift-merge-bot · 2026-08-11T19:24:33Z

Pipeline controller notification

The pipeline-auto label has been added to this PR. Second-stage tests will be triggered automatically when all first-stage tests pass.

damdo · 2026-08-11T19:26:49Z

/assign @everettraven

openshift-merge-bot · 2026-08-11T19:42:00Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

mtulio · 2026-08-11T19:53:14Z

/test verify-hypershift-integration

mtulio · 2026-08-11T20:04:04Z

expect all tests with prefix [cloud-provider-aws-e2e-* passing or skipped.
/hold
/test e2e-aws-ovn-hypershift-conformance

openshift-merge-bot · 2026-08-11T23:59:51Z

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

damdo · 2026-08-12T09:01:44Z

/retest

openshift-ci · 2026-08-12T13:04:47Z

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

everettraven · 2026-08-12T15:33:45Z

Everything looks good here to me, thanks folks!

/lgtm
/approve
/verified by ci

This is already held, but adding an additional comment for this to prevent this from merging until after branching to decrease instability risk for 5.0 branching. Feel free to remove the hold after branching activities have been completed.

/hold

openshift-ci-robot · 2026-08-12T15:33:58Z

@everettraven: This PR has been marked as verified by ci.

Details

In response to this:

Everything looks good here to me, thanks folks!

/lgtm
/approve
/verified by ci

This is already held, but adding an additional comment for this to prevent this from merging until after branching to decrease instability risk for 5.0 branching. Feel free to remove the hold after branching activities have been completed.

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-08-12T15:36:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, mfbonfigli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [everettraven]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2026

openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 10, 2026

coderabbitai Bot mentioned this pull request Aug 10, 2026

OCPBUGS-105407: Remove VSphereMultiNetworks feature gate #2975

Open

damdo mentioned this pull request Aug 10, 2026

OCPBUGS-105409: chore: remove AWSServiceLBNetworkSecurityGroup feature gate references openshift/cluster-cloud-controller-manager-operator#500

Merged

3 tasks

openshift-ci Bot assigned mfbonfigli and mtulio Aug 11, 2026

damdo marked this pull request as ready for review August 11, 2026 10:31

openshift-ci Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 11, 2026

openshift-ci Bot requested review from JoelSpeed and everettraven August 11, 2026 10:31

everettraven reviewed Aug 11, 2026

View reviewed changes

Comment thread tools/codegen/cmd/featuregate-test-analyzer_test.go Outdated

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2026

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2026

chore: remove AWSServiceLBNetworkSecurityGroup feature gate

f89b3ce

The AWSServiceLBNetworkSecurityGroup feature gate has been enabled by default across all profiles and feature sets, making it redundant. Remove the gate definition and regenerate payload manifests.

damdo force-pushed the chore-remove-aws-service-lb-network-security-group-featuregate branch from 8c88df5 to f89b3ce Compare August 11, 2026 18:45

damdo changed the title ~~chore: remove AWSServiceLBNetworkSecurityGroup feature gate~~ OCPBUGS-105409: chore: remove AWSServiceLBNetworkSecurityGroup feature gate Aug 11, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 11, 2026

openshift-merge-bot Bot added the pipeline-auto label Aug 11, 2026

damdo requested a review from everettraven August 11, 2026 19:24

openshift-ci Bot assigned everettraven Aug 11, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 12, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2026

Uh oh!

Conversation

damdo commented Aug 10, 2026

Summary

Test plan

Uh oh!

openshift-merge-bot Bot commented Aug 10, 2026

Uh oh!

openshift-ci Bot commented Aug 10, 2026

Uh oh!

openshift-ci Bot commented Aug 10, 2026

Uh oh!

coderabbitai Bot commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

damdo commented Aug 11, 2026

Uh oh!

damdo commented Aug 11, 2026

Uh oh!

qodo-for-rh-openshift Bot commented Aug 11, 2026

PR Summary by Qodo

Uh oh!

qodo-for-rh-openshift Bot commented Aug 11, 2026

Code Review by Qodo

Great, no issues found!

Uh oh!

damdo commented Aug 11, 2026

Uh oh!

Uh oh!

mfbonfigli commented Aug 11, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 11, 2026

Uh oh!

openshift-ci-robot commented Aug 11, 2026

Summary

Test plan

Uh oh!

damdo commented Aug 11, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 11, 2026

Uh oh!

damdo commented Aug 11, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 11, 2026

Uh oh!

mtulio commented Aug 11, 2026

Uh oh!

mtulio commented Aug 11, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 11, 2026

Uh oh!

damdo commented Aug 12, 2026

Uh oh!

openshift-ci Bot commented Aug 12, 2026

Uh oh!

everettraven commented Aug 12, 2026

Uh oh!

openshift-ci-robot commented Aug 12, 2026

Uh oh!

openshift-ci Bot commented Aug 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coderabbitai Bot commented Aug 10, 2026 •

edited

Loading