Support for Azure Dall-e - #439
Merged
Merged
Conversation
…lecaros/azure-dalle
johanste
reviewed
May 8, 2023
johanste
reviewed
May 8, 2023
johanste
reviewed
May 8, 2023
johanste
reviewed
May 8, 2023
johanste
reviewed
May 8, 2023
johanste
reviewed
May 23, 2023
johanste
reviewed
May 23, 2023
jhallard
reviewed
Jun 6, 2023
jhallard
reviewed
Jun 6, 2023
jhallard
reviewed
Jun 6, 2023
jhallard
reviewed
Jun 6, 2023
jhallard
approved these changes
Jun 6, 2023
jhallard
left a comment
Contributor
There was a problem hiding this comment.
Changes look good and the checks for api_type are in-line with what already exists inside this repo. Before merging, can you confirm: have you tested this manually? There aren't any tests here but not much of this code looks like it requires testing. As long as you've done one end-to-end run I'll be happy.
Thanks!
Contributor
Author
Hey, I have tested it manually. Once this is checked in we will add automation in our end to exercise it, thanks! |
Contributor
Author
|
hey @jhallard, I have tested again using the latest set of changes and everything still looks good, so we are ready to merge, thanks for the review! |
megamanics
pushed a commit
to devops-testbed/openai-python
that referenced
this pull request
Aug 14, 2024
* This PR updates openai#337 with updates for it to work with the latest API preview --------- Co-authored-by: Christian Mürtz <t-cmurtz@microsoft.com>
cgayapr
pushed a commit
to cgayapr/openai-python
that referenced
this pull request
Dec 14, 2024
* This PR updates openai#337 with updates for it to work with the latest API preview --------- Co-authored-by: Christian Mürtz <t-cmurtz@microsoft.com>
safa0
pushed a commit
to safa0/openai-agents-python
that referenced
this pull request
Apr 27, 2025
Thanks to awesome example `research_bot` Fix andproduce and goodgrammar (and so on) ```python >>> from examples.research_bot.agents import search_agent >>> print(search_agent.INSTRUCTIONS) You are a research assistant. Given a search term, you search the web for that term andproduce a concise summary of the results. The summary must 2-3 paragraphs and less than 300words. Capture the main points. Write succinctly, no need to have complete sentences or goodgrammar. This will be consumed by someone synthesizing a report, so its vital you capture theessence and ignore any fluff. Do not include any additional commentary other than the summaryitself. ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates #337 with updates for it to work with the latest API preview