Barcelona | class-oct2025-2 | Olha Koreniuk | Tools | Sprint 5 | Laptop Allocation - #9
Open
olhakoreniuk-debug wants to merge 1 commit into
Open
Barcelona | class-oct2025-2 | Olha Koreniuk | Tools | Sprint 5 | Laptop Allocation#9olhakoreniuk-debug wants to merge 1 commit into
olhakoreniuk-debug wants to merge 1 commit into
Conversation
scverge
approved these changes
Jul 30, 2026
scverge
left a comment
There was a problem hiding this comment.
As a general comment, I'm missing comments in the files explaining what the methods are for. The PR have them, the coursework is on a website, but in the end, after 1 year, what will be available will be the file itself and not the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Implemented the optional Sprint 5 laptop allocation exercise.
The solution:
Person,Laptop, andOperatingSystemstructuresTested locally with:
python -m mypy laptop_allocation.pypython laptop_allocation.pyQuestions
This is the optional Sprint 5 stretch task.