Manages datastore contention with exponential backoff [v5] #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backport changes from master: 137c373 Fred Wulff <frew@cs.stanford.edu> on 2018. 09. 07. at 21:09
…erruptedException in exponential backoff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we try to save the entity in a transaction we are getting a lot of datastore contention exception.
We can reduce their number by randomly suspending a given thread for a while and retrying it a little bit later.
As I have seen in there was implemented a solution for it on the master.
Based on that created the same into Objectify v5.
I have added a small improvement:
Let the caller handle ConcurrentModificationException when we got InterruptedException in exponential backoff.
This change is