Skip to content

Dont throw when querying for a parent class of a subclass that has a … #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
daswass wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Dont throw when querying for a parent class of a subclass that has a … #453

daswass wants to merge 1 commit into from

Conversation

@daswass
Copy link

@daswass daswass commented Apr 16, 2020

…parent

@daswass
Copy link
Author

daswass commented Apr 16, 2020 •
edited
Loading

Relates to #452

Side note, the underlying object (subtype) has the @parent fully populated because ClassPopulator#load first hits superPopulator, where it currently throws unnecessarily, and then populates the Parent key on the object itself.

@daswass daswass mentioned this pull request Apr 16, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@daswass @eman3488