ENH: Add commented_names parameter to genfromtxt #31984
Open
Aniketsy wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
ahh, i think this needs stub update as well, (moving in draft for now) , needs to update docstring too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #389
PR summary
i followed @WarrenWeckesser suggestion
added a new
commented_namesoption togenfromtxtso we can control exactly where it look for column names, instead of guessing based on comments.set
commented_names=Trueto grab the names from the last comment line before the data starts orcommented_names=Falseto skip all commentsleft the default behaviour
commented_names=NoneunchangedAs its quite old issue (2012) , excited to move forward with this 😀
First time committer introduction
AI Disclosure
So lets call this work done by Semi-human