BUG: add sorted=False to unique_all, unique_counts, unique_inverse#31244
Open
Jah-yee wants to merge 1 commit intonumpy:mainfrom
Open
BUG: add sorted=False to unique_all, unique_counts, unique_inverse#31244Jah-yee wants to merge 1 commit intonumpy:mainfrom
sorted=False to unique_all, unique_counts, unique_inverse#31244Jah-yee wants to merge 1 commit intonumpy:mainfrom
Conversation
The docstrings claim equivalence to np.unique(..., sorted=False), but the source was missing sorted=False parameter. Added to match unique_values which was fixed in NumPy 2.3. See: numpy/issues/31241
sorted=False to unique_all, unique_counts, unique_inverse
Member
|
The linter failure is unrelated to this PR. That said, it'd be nice to have tests that demonstrate that these keywords are being passed. It looks like none of our existing tests demonstrate that and that means this could regress again in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
The docstrings claim equivalence to
np.unique(..., sorted=False), but the source was missing thesorted=Falseparameter. This fix adds it tounique_all,unique_counts, andunique_inverseto matchunique_values, which was fixed in NumPy 2.3.See: /issues/31241
Thank you for your work on this project. I hope this small fix is helpful. Please let me know if there's anything to adjust.
Warmly, RoomWithOutRoof