tools: update android builds to use 16kb page size - #154
Merged
Conversation
achou11
commented
Nov 10, 2025
Comment on lines
+23
to
+25
| - { os: ubuntu-22.04, target_arch: arm } | ||
| - { os: ubuntu-22.04, target_arch: arm64 } | ||
| - { os: ubuntu-22.04, target_arch: x86_64 } |
Contributor
Author
There was a problem hiding this comment.
Github no longer provides a hosted 20.04 runner image.
| matrix: | ||
| config: | ||
| - { os: ubuntu-20.04 } | ||
| - { os: ubuntu-22.04 } |
Contributor
Author
There was a problem hiding this comment.
Github no longer provides a hosted 20.04 runner image.
| - name: Build | ||
| env: | ||
| MY_ANDROID_NDK_HOME: ${{ steps.setup-ndk.outputs.ndk-path }} | ||
| LDFLAGS: '-Wl,-z,max-page-size=16384' |
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
|
Downloaded the artifact from https://github.com/nodejs-mobile/nodejs-mobile/actions/runs/19238325194?pr=154 and ran the following: $ANDROID_SDK_ROOT/ndk/24.0.8215888/toolchains/llvm/prebuilt/darwin-x86_64/bin/llvm-objdump -p ~/Downloads/x86_64/libnode.so | grep LOADwhich has the following output: LOAD off 0x0000000000000000 vaddr 0x0000000000000000 paddr 0x0000000000000000 align 2**14
LOAD off 0x00000000015e94c0 vaddr 0x00000000015ed4c0 paddr 0x00000000015ed4c0 align 2**14
LOAD off 0x00000000032e63f0 vaddr 0x00000000032ee3f0 paddr 0x00000000032ee3f0 align 2**14
LOAD off 0x000000000340d290 vaddr 0x0000000003419290 paddr 0x0000000003419290 align 2**14 |
Contributor
Author
|
Confirming usage of the built assets from this PR works for our app. Screenshots from APK analyzer in Android Studio for a dev apk build: 
|
gmaclennan
approved these changes
Nov 13, 2025
gmaclennan
added a commit
that referenced
this pull request
Nov 17, 2025
Prepare for release v18.20.4+16kb-fix with the 16kb page alignment from [#154](#154) to address page size alignment requirements for Google Play Relevant links: - https://android-developers.googleblog.com/2025/05/prepare-play-apps-for-devices-with-16kb-page-size.html - https://developer.android.com/guide/practices/page-sizes
Closed
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #148
Attempts to do the bare minimum in terms of fulfilling the page size requirements required by Google Play. Haven't actually tested this locally, but hoping the workflow on CI can be used to confirm.
Relevant links: