Update22-9-0. fixed ios and android builds - #150
Open
alzhuravlev wants to merge 29 commits into
Open
Conversation
Update22 9 0
gmaclennan
pushed a commit
to gmaclennan/nodejs-mobile
that referenced
this pull request
Apr 30, 2026
Updates the upstream-sync procedure to maintain mobile-specific changes as a stack of atomic, individually-attributable commits rebased on top of an upstream release tag. The squash-merge format-patch workflow has been the basis of every nodejs-mobile release to date and reflects significant sustained work by maintainers; the patch-stack model is intended to make the next major upgrade more incremental, by scoping conflicts to single patches and making each mobile change reviewable on its own. The model follows the approach demonstrated by Valodim on PR nodejs-mobile#151 and implemented on heylogin/nodejs-mobile@icu. Adds doc_mobile/UPGRADING.md as the canonical rebase procedure; rewrites doc_mobile/CONTRIBUTING.md to document the branch layout and per-commit discipline. Refs: nodejs-mobile#134, nodejs-mobile#150, nodejs-mobile#151
gmaclennan
pushed a commit
to gmaclennan/nodejs-mobile
that referenced
this pull request
Apr 30, 2026
Inventories the known issues from PRs nodejs-mobile#134, nodejs-mobile#150, nodejs-mobile#151 and the heylogin patch stack. Each blocker has a verification command, likely cause, and a proposed fix path so contributors can pick one up without re-deriving the diagnosis. Two blockers from earlier PRs are already resolved by patches inherited from heylogin/icu (host-toolchain split, NDK CRC32 crash); marked as such under "Resolved".
gmaclennan
added a commit
to gmaclennan/nodejs-mobile
that referenced
this pull request
Apr 30, 2026
Adds a canonical description of the patch-stack maintenance model on which mobile/v24 is based. The mobile-specific changes live as discrete, atomic commits on top of an upstream nodejs/node release tag, so each patch is reviewable and individually rebaseable when upstream moves. The squash-merge format-patch workflow has been the basis of every nodejs-mobile release to date and reflects significant sustained work by maintainers; the patch-stack model is intended to make the next major upgrade more incremental, by scoping conflicts to single patches and making each mobile change reviewable on its own. The model follows the approach demonstrated by Valodim on nodejs-mobile#151 and implemented on heylogin/nodejs-mobile@icu. doc_mobile/MAINTENANCE_MODEL.md is the strategy overview; doc_mobile/UPGRADING.md is the canonical step-by-step rebase procedure. The legacy doc_mobile/CONTRIBUTING.md (carrying the deprecated format-patch instructions) lives on the legacy main branch and will land on mobile/v24 via a later layer-A patch import; a follow-up commit will wire the two together. Refs: nodejs-mobile#134, nodejs-mobile#150, nodejs-mobile#151
gmaclennan
added a commit
to gmaclennan/nodejs-mobile
that referenced
this pull request
Apr 30, 2026
Inventories the known issues from PRs nodejs-mobile#134, nodejs-mobile#150, nodejs-mobile#151 and the heylogin patch stack. Each blocker has a verification command, likely cause, and a proposed fix path so contributors can pick one up without re-deriving the diagnosis. Two blockers from earlier PRs are already resolved by patches that will be inherited from heylogin/icu when layer-B lands (host-toolchain split, NDK CRC32 crash); marked as such under "Resolved". Refs: nodejs-mobile#134, nodejs-mobile#150, nodejs-mobile#151
This was referenced Apr 30, 2026
gmaclennan
added a commit
to gmaclennan/nodejs-mobile
that referenced
this pull request
May 29, 2026
mobile/v24 is maintained as a patch stack on top of an upstream nodejs/node release tag (recorded in doc_mobile/upstream-base.txt). MAINTENANCE_MODEL.md describes the model and branch layout; UPGRADING.md is the canonical rebase procedure for moving to a newer upstream version. Refs: nodejs-mobile#134, nodejs-mobile#150, nodejs-mobile#151
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.