Skip to content

fix(git-node): pass argv to LandingSession constructor#1039

Merged
aduh95 merged 1 commit intonodejs:mainfrom
aduh95:fix-landing-session
Mar 20, 2026
Merged

fix(git-node): pass argv to LandingSession constructor#1039
aduh95 merged 1 commit intonodejs:mainfrom
aduh95:fix-landing-session

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 20, 2026

Without it, the code assumes we're on the nodejs/node repository even if given a URL for a different one

@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.94%. Comparing base (478250b) to head (b4bad31).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1039   +/-   ##
=======================================
  Coverage   80.94%   80.94%           
=======================================
  Files          39       39           
  Lines        4829     4829           
=======================================
  Hits         3909     3909           
  Misses        920      920           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 merged commit 8224122 into nodejs:main Mar 20, 2026
13 checks passed
@aduh95 aduh95 deleted the fix-landing-session branch March 20, 2026 18:01
This was referenced Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants