fix(ncu-config): allow overriding global encrypted keys with local ones#1030
Merged
aduh95 merged 3 commits intonodejs:mainfrom Mar 20, 2026
Merged
fix(ncu-config): allow overriding global encrypted keys with local ones#1030aduh95 merged 3 commits intonodejs:mainfrom
aduh95 merged 3 commits intonodejs:mainfrom
Conversation
If a value is defined locally, it should make no difference whether the associated key is present or not in the global config.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1030 +/- ##
==========================================
+ Coverage 80.71% 80.93% +0.22%
==========================================
Files 39 39
Lines 4754 4841 +87
==========================================
+ Hits 3837 3918 +81
- Misses 917 923 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Ping @nodejs/node-core-utils for reviews |
juanarbol
approved these changes
Mar 20, 2026
RafaelGSS
approved these changes
Mar 20, 2026
This was referenced Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a value is defined locally, it should make no difference whether the associated key is present or not in the global config.
I hit that as I tried setting a temp GH token to access the private repo for the security release, and got an error sent from the encrypted value setter, which gets reached because
Object.assigncalls it.