Skip to content

tools: fix error detection#914

Merged
mhdawson merged 1 commit intonodejs:mainfrom
RaisinTen:tools-fix-error-detection
Feb 23, 2021
Merged

tools: fix error detection#914
mhdawson merged 1 commit intonodejs:mainfrom
RaisinTen:tools-fix-error-detection

Conversation

@RaisinTen
Copy link
Copy Markdown
Member

The ChildProces object result does not have an error property. We
should use stderr instead.

The `ChildProces` object `result` does not have an `error` property. We
should use `stderr` instead.
Copy link
Copy Markdown
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 12c548b into nodejs:main Feb 23, 2021
@RaisinTen RaisinTen deleted the tools-fix-error-detection branch February 24, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants