Skip to content

test: load testModules automatically#876

Closed
RaisinTen wants to merge 1 commit intonodejs:masterfrom
RaisinTen:test/load-testModules-automatically
Closed

test: load testModules automatically#876
RaisinTen wants to merge 1 commit intonodejs:masterfrom
RaisinTen:test/load-testModules-automatically

Conversation

@RaisinTen
Copy link
Copy Markdown
Member

No description provided.

@RaisinTen
Copy link
Copy Markdown
Member Author

@mhdawson I have added the multilevel traversal feature and the explicit '.js' extension check as discussed in the meeting. Also added a TODO comment so that the filtering in this function is updated when the test filenames are changed into test_*.js.

Copy link
Copy Markdown
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Copy Markdown
Member

mhdawson commented Jan 8, 2021

@RaisinTen thanks for the recent PRs. I'll give the other team members a bit of time to review and try to land this late next week.

@RaisinTen RaisinTen force-pushed the test/load-testModules-automatically branch from eb14116 to 76b3cfc Compare January 9, 2021 08:23
mhdawson pushed a commit that referenced this pull request Jan 12, 2021
PR-URL: #876
Reviewed-By: Michael Dawson <midawson@redhat.com>
@mhdawson
Copy link
Copy Markdown
Member

Landed as 1c040ee

@mhdawson mhdawson closed this Jan 12, 2021
@RaisinTen RaisinTen deleted the test/load-testModules-automatically branch January 13, 2021 08:20
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
PR-URL: nodejs/node-addon-api#876
Reviewed-By: Michael Dawson <midawson@redhat.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
PR-URL: nodejs/node-addon-api#876
Reviewed-By: Michael Dawson <midawson@redhat.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
PR-URL: nodejs/node-addon-api#876
Reviewed-By: Michael Dawson <midawson@redhat.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
PR-URL: nodejs/node-addon-api#876
Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants