Fix leak of ThreadSafeData in AsyncProgressWorkerBase<DataType>#795
Closed
fholzer wants to merge 1 commit intonodejs:masterfrom
Closed
Fix leak of ThreadSafeData in AsyncProgressWorkerBase<DataType>#795fholzer wants to merge 1 commit intonodejs:masterfrom
fholzer wants to merge 1 commit intonodejs:masterfrom
Conversation
Contributor
Author
|
@legendecas @mhdawson any thoughts on this? |
Member
|
I know @gabrielschulhof has some concerns when we looked at it in the meeting last week. I've not had a chance to take a look myself yet. |
legendecas
approved these changes
Sep 8, 2020
Member
legendecas
left a comment
There was a problem hiding this comment.
LGTM. Sorry for the delayed review 😅
Member
|
Still want @gabrielschulhof to take a look at this one. |
gabrielschulhof
approved these changes
Sep 18, 2020
mhdawson
pushed a commit
that referenced
this pull request
Sep 22, 2020
Fix leak of ThreadSafeData in AsyncProgressWorkerBase<DataType> PR-URL: #795 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Member
|
Landed as ceb27d4 |
Superlokkus
pushed a commit
to Superlokkus/node-addon-api
that referenced
this pull request
Nov 20, 2020
Fix leak of ThreadSafeData in AsyncProgressWorkerBase<DataType> PR-URL: nodejs#795 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Fix leak of ThreadSafeData in AsyncProgressWorkerBase<DataType> PR-URL: nodejs/node-addon-api#795 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Fix leak of ThreadSafeData in AsyncProgressWorkerBase<DataType> PR-URL: nodejs/node-addon-api#795 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Fix leak of ThreadSafeData in AsyncProgressWorkerBase<DataType> PR-URL: nodejs/node-addon-api#795 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Fix leak of ThreadSafeData in AsyncProgressWorkerBase<DataType> PR-URL: nodejs/node-addon-api#795 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThreadSafeDatais allocated inAsyncProgressWorkerBase<DataType>::NonBlockingCallto provide context in thetsfncallback, but never deleted.