src: explicitly disallow assign and copy#590
src: explicitly disallow assign and copy#590legendecas wants to merge 1 commit intonodejs:masterfrom
Conversation
|
Hi @legendecas, |
|
@NickNaso I found that this is what's done in Node.js core, v8, and NAN, lots of C++ projects. It can not be denied that with macros we could not get first sight of what's done after the macro expansion. Yet since disallowing assign/copy/move operations are so commonly used, and I cannot assume it would be easy to write such things every time without missing something. So a macro with a straightforward name describing what it would do will be helpful. And I'd assume it would not be confusing very much on this use case. |
|
@legendecas could you please rebase? |
|
@gabrielschulhof rebased :D |
PR-URL: #590 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
|
Landed in 79deefb. |
PR-URL: nodejs/node-addon-api#590 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: nodejs/node-addon-api#590 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: nodejs/node-addon-api#590 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: nodejs/node-addon-api#590 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Use macros to explicitly disallow assign and copy.
npm testpassed.