Skip to content

Use IsEmpty to check for empty value #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NickNaso wants to merge 1 commit into from
Closed

Use IsEmpty to check for empty value #478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions napi-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ inline bool Value::IsEmpty() const {
}

inline napi_valuetype Value::Type() const {
if (_value == nullptr) {
if (IsEmpty()) {
return napi_undefined;
}

Expand Down Expand Up @@ -314,7 +314,7 @@ inline bool Value::IsSymbol() const {
}

inline bool Value::IsArray() const {
if (_value == nullptr) {
if (IsEmpty()) {
return false;
}

Expand All @@ -325,7 +325,7 @@ inline bool Value::IsArray() const {
}

inline bool Value::IsArrayBuffer() const {
if (_value == nullptr) {
if (IsEmpty()) {
return false;
}

Expand All @@ -336,7 +336,7 @@ inline bool Value::IsArrayBuffer() const {
}

inline bool Value::IsTypedArray() const {
if (_value == nullptr) {
if (IsEmpty()) {
return false;
}

Expand All @@ -355,7 +355,7 @@ inline bool Value::IsFunction() const {
}

inline bool Value::IsPromise() const {
if (_value == nullptr) {
if (IsEmpty()) {
return false;
}

Expand All @@ -366,7 +366,7 @@ inline bool Value::IsPromise() const {
}

inline bool Value::IsDataView() const {
if (_value == nullptr) {
if (IsEmpty()) {
return false;
}

Expand All @@ -377,7 +377,7 @@ inline bool Value::IsDataView() const {
}

inline bool Value::IsBuffer() const {
if (_value == nullptr) {
if (IsEmpty()) {
return false;
}

Expand Down