Skip to content

Added .npmrc for setting package-lock to false#359

Closed
yjaeseok wants to merge 3 commits intonodejs:masterfrom
yjaeseok:gitignore
Closed

Added .npmrc for setting package-lock to false#359
yjaeseok wants to merge 3 commits intonodejs:masterfrom
yjaeseok:gitignore

Conversation

@yjaeseok
Copy link
Copy Markdown
Contributor

@yjaeseok yjaeseok commented Oct 2, 2018

npm install creates a package-lock.json to lock the versions of dependencies that are installed.
They recommend to commit this file and that's what I usually do in other projects but I think we should gitignore it in CITGM.
This will allow us to always test the latest version of our dependencies (especially in CI).

@yjaeseok
Added package-lock.json file to gitignore
7be6f14 
```npm install``` creates a ```package-lock.json``` to lock the versions of dependencies that are installed.
They recommend to commit this file and that's what I usually do in other projects but I think we should gitignore it in CITGM.
This will allow us to always test the latest version of our dependencies (especially in CI).
@NickNaso
Copy link
Copy Markdown
Member

NickNaso commented Oct 2, 2018

I was thinking at same thing, but my solution was to eliminate the package-lock.json and add the file .npmrc with package-lock=false. What do you think?
@mhdawson @gabrielschulhof Are you agree with the idea to exclude / remove the package-lock.json?

@yjaeseok
Copy link
Copy Markdown
Contributor Author

yjaeseok commented Oct 2, 2018

I agree with your opinion ~. :)

@yjaeseok
Copy link
Copy Markdown
Contributor Author

yjaeseok commented Oct 2, 2018

What do you think it? @mhdawson @gabrielschulhof

@mhdawson
Copy link
Copy Markdown
Member

mhdawson commented Oct 2, 2018

+1 from me.

@NickNaso
Copy link
Copy Markdown
Member

NickNaso commented Oct 5, 2018

Hi @nodejs/n-api can @yjaeseok continue to go forward with his proposal? Is there any objection?

@devsnek
Copy link
Copy Markdown
Member

devsnek commented Oct 5, 2018

fwiw using package-lock.json in any library doesn't make sense because npm doesn't use it in that context. it should just be removed completely anyway.

@NickNaso
Copy link
Copy Markdown
Member

NickNaso commented Oct 7, 2018

Hi @yjaeseok, I think that there are not objections about you PR so please if you need to complete something do it and then just ping here to get a review.

@yjaeseok yjaeseok changed the title Added package-lock.json file to gitignore Added .npmrc for setting package-lock to false Oct 9, 2018
@yjaeseok
Copy link
Copy Markdown
Contributor Author

yjaeseok commented Oct 9, 2018

@NickNaso I updated it as you mention, Please review again :)

NickNaso
NickNaso approved these changes Oct 9, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson
mhdawson approved these changes Oct 9, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson pushed a commit that referenced this pull request Oct 22, 2018
@yjaeseok @mhdawson
build: avoid using package-lock.json
8ce605c 
```npm install``` creates a ```package-lock.json``` to lock
the versions of dependencies that are installed.
They recommend to commit this file and that's what I
usually do in other projects but we should not use it
for this project.  This will allow us to always test
the latest version of our dependencies (especially in CI).

PR-URL: #359
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
@mhdawson
Copy link
Copy Markdown
Member

mhdawson commented Oct 22, 2018

Landed as 8ce605c

@mhdawson mhdawson closed this Oct 22, 2018
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
@kevindavies8
build: avoid using package-lock.json
6c850ec 
```npm install``` creates a ```package-lock.json``` to lock
the versions of dependencies that are installed.
They recommend to commit this file and that's what I
usually do in other projects but we should not use it
for this project.  This will allow us to always test
the latest version of our dependencies (especially in CI).

PR-URL: nodejs/node-addon-api#359
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
@Marlyfleitas
build: avoid using package-lock.json
5ce1402 
```npm install``` creates a ```package-lock.json``` to lock
the versions of dependencies that are installed.
They recommend to commit this file and that's what I
usually do in other projects but we should not use it
for this project.  This will allow us to always test
the latest version of our dependencies (especially in CI).

PR-URL: nodejs/node-addon-api#359
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
@wroy7860
build: avoid using package-lock.json
0ddb3ac 
```npm install``` creates a ```package-lock.json``` to lock
the versions of dependencies that are installed.
They recommend to commit this file and that's what I
usually do in other projects but we should not use it
for this project.  This will allow us to always test
the latest version of our dependencies (especially in CI).

PR-URL: nodejs/node-addon-api#359
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
build: avoid using package-lock.json
a4cd93e 
```npm install``` creates a ```package-lock.json``` to lock
the versions of dependencies that are installed.
They recommend to commit this file and that's what I
usually do in other projects but we should not use it
for this project.  This will allow us to always test
the latest version of our dependencies (especially in CI).

PR-URL: nodejs/node-addon-api#359
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickNaso NickNaso NickNaso approved these changes

@mhdawson mhdawson mhdawson approved these changes

+1 more reviewer

@thefourtheye thefourtheye thefourtheye approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yjaeseok @NickNaso @mhdawson @devsnek @thefourtheye