test: add ability to control experimental tests#350
Closed
mhdawson wants to merge 9 commits intonodejs:masterfrom
Closed
test: add ability to control experimental tests#350mhdawson wants to merge 9 commits intonodejs:masterfrom
mhdawson wants to merge 9 commits intonodejs:masterfrom
Conversation
Add the ability to specify a NAPI_VERSION which limits the tests executed to those supported by that version. As an example tests can be built/run as: npm test --NAPI_VERSION=3 Fixes: nodejs#349
It needs to be in its own file so we can avoid loading it completely on earlier Node.js versions
Member
Author
|
FYI, passed CI runs on my branch for 10.x, 8.x. 6.x and master. |
devsnek
reviewed
Sep 20, 2018
devsnek
approved these changes
Sep 20, 2018
thefourtheye
approved these changes
Sep 20, 2018
| // currently experimental only test if NAPI_VERSION | ||
| // is set to experimental. We can't use C max int | ||
| // as that is not supported as a number on earlier | ||
| // Node.js versions. Oonce bigint is in a release |
romandev
approved these changes
Sep 20, 2018
| 'version_management' | ||
| ]; | ||
|
|
||
| if((process.env.npm_config_NAPI_VERSION !== undefined) && |
Member
Author
There was a problem hiding this comment.
Thanks for catching that.
mhdawson
added a commit
that referenced
this pull request
Sep 20, 2018
Add the ability to specify a NAPI_VERSION which limits the tests executed to those supported by that version. As an example tests can be built/run as: npm test --NAPI_VERSION=3 Fixes: #349 PR-URL: #350 Fixes: #349 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Jinho Bang <zino@chromium.org>
mhdawson
added a commit
that referenced
this pull request
Sep 20, 2018
Add the ability to specify a NAPI_VERSION which limits the tests executed to those supported by that version. As an example tests can be built/run as: npm test --NAPI_VERSION=3 PR-URL: #350 Fixes: #349 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Jinho Bang <zino@chromium.org>
Member
Author
|
Landed as 73fed84 |
Member
Author
|
CI run that tests across Node.js versions: https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api-LTS%20versions/80/ |
Member
Author
|
CI back to green ,closing. |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Add the ability to specify a NAPI_VERSION which limits the tests executed to those supported by that version. As an example tests can be built/run as: npm test --NAPI_VERSION=3 PR-URL: nodejs/node-addon-api#350 Fixes: nodejs/node-addon-api#349 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Jinho Bang <zino@chromium.org>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Add the ability to specify a NAPI_VERSION which limits the tests executed to those supported by that version. As an example tests can be built/run as: npm test --NAPI_VERSION=3 PR-URL: nodejs/node-addon-api#350 Fixes: nodejs/node-addon-api#349 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Jinho Bang <zino@chromium.org>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Add the ability to specify a NAPI_VERSION which limits the tests executed to those supported by that version. As an example tests can be built/run as: npm test --NAPI_VERSION=3 PR-URL: nodejs/node-addon-api#350 Fixes: nodejs/node-addon-api#349 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Jinho Bang <zino@chromium.org>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Add the ability to specify a NAPI_VERSION which limits the tests executed to those supported by that version. As an example tests can be built/run as: npm test --NAPI_VERSION=3 PR-URL: nodejs/node-addon-api#350 Fixes: nodejs/node-addon-api#349 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Jinho Bang <zino@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to specify a NAPI_VERSION which
limits the tests executed to those supported by that
version.
As an example tests can be built/run as:
npm test --NAPI_VERSION=3
Fixes: #349