Added Call and MakeCallback that accept cargs as agruments#344
Closed
NickNaso wants to merge 3 commits intonodejs:masterfrom
NickNaso:function-reference-cargs
Closed
Added Call and MakeCallback that accept cargs as agruments#344NickNaso wants to merge 3 commits intonodejs:masterfrom NickNaso:function-reference-cargs
NickNaso wants to merge 3 commits intonodejs:masterfrom
NickNaso:function-reference-cargs
Conversation
Member
|
Looks good, but the 2 methods need to be added to the doc as well. |
Member
Author
|
Ok added the requested documentation |
thefourtheye
left a comment
There was a problem hiding this comment.
Few typos in the commit message as well.
|
|
||
| ### Call | ||
|
|
||
| Calls a referenced Javascript function from a native add-on. |
There was a problem hiding this comment.
Nit: JavaScript is used with different cases in the file.
| ``` | ||
|
|
||
| - `[in] recv`: The `this` object passed to the referenced function when it's called. | ||
| - `[in] argc`: The number of the arguments passed to the referenced function. |
Member
Author
|
@thefourtheye Fixed typos for the the methods added in this PR. I will provide to fix the remaining typos in this PR #335 |
mhdawson
pushed a commit
that referenced
this pull request
Sep 20, 2018
PR-URL: #344 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Member
|
Landed as 97c4ab5 |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
PR-URL: nodejs/node-addon-api#344 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
PR-URL: nodejs/node-addon-api#344 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
PR-URL: nodejs/node-addon-api#344 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
PR-URL: nodejs/node-addon-api#344 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added methods to
Napi::FunctionReferencelike requested and discussed on the issue #320Below I report the added methods: