Leave platform-specific type in operator def.n#341
Closed
gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
Closed
Leave platform-specific type in operator def.n#341gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
Conversation
Contributor
Author
Contributor
Author
Member
|
After discussion with Gabriel, it seems that changing the type only shifts which cases we'd have to cast so it better to just add a cast to the test. |
ba4ad76 to
d7e10e9
Compare
Explicitly casting to `uint32_t` prevents a template resolution ambiguity on 32-bit platforms. Fixes: nodejs#337
d7e10e9 to
186c492
Compare
Member
|
Landed as 2ad47a8 |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Explicitly casting to `uint32_t` prevents a template resolution ambiguity on 32-bit platforms. Fixes: nodejs/node-addon-api#337 PR-URL: nodejs/node-addon-api#341 Fixes: nodejs/node-addon-api#337 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Explicitly casting to `uint32_t` prevents a template resolution ambiguity on 32-bit platforms. Fixes: nodejs/node-addon-api#337 PR-URL: nodejs/node-addon-api#341 Fixes: nodejs/node-addon-api#337 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Explicitly casting to `uint32_t` prevents a template resolution ambiguity on 32-bit platforms. Fixes: nodejs/node-addon-api#337 PR-URL: nodejs/node-addon-api#341 Fixes: nodejs/node-addon-api#337 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Explicitly casting to `uint32_t` prevents a template resolution ambiguity on 32-bit platforms. Fixes: nodejs/node-addon-api#337 PR-URL: nodejs/node-addon-api#341 Fixes: nodejs/node-addon-api#337 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The property get/set sugar for numerical indices has to stay platform-
agnostic. That is, we cannot use
uint32_t, but must instead useintin the operator definition, because
intresolves exactly on both32-bit and 64-bit platforms.
Fixes: #337