Napi::ObjectWrap example does not compile#339
Closed
BotellaA wants to merge 1 commit intonodejs:masterfrom
BotellaA:patch-1
Closed
Napi::ObjectWrap example does not compile#339BotellaA wants to merge 1 commit intonodejs:masterfrom BotellaA:patch-1
BotellaA wants to merge 1 commit intonodejs:masterfrom
BotellaA:patch-1
Conversation
The current example does not compile using GCC 4.8.
mhdawson
approved these changes
Sep 13, 2018
Member
mhdawson
left a comment
There was a problem hiding this comment.
LGTM assuming you have compiled it and confirm it passes with your changes.
Contributor
Author
|
@mhdawson Yes, I compiled it and it compiles, assuming you provide at some point an implementation for the methods but it is OK for the example. |
mhdawson
pushed a commit
that referenced
this pull request
Sep 18, 2018
The current example does not compile using GCC 4.8. PR-URL: #339 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Member
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
The current example does not compile using GCC 4.8. PR-URL: nodejs/node-addon-api#339 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
The current example does not compile using GCC 4.8. PR-URL: nodejs/node-addon-api#339 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
The current example does not compile using GCC 4.8. PR-URL: nodejs/node-addon-api#339 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
The current example does not compile using GCC 4.8. PR-URL: nodejs/node-addon-api#339 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current example does not compile using GCC 4.8.