Closed
Conversation
mhdawson
approved these changes
Feb 14, 2018
Member
mhdawson
left a comment
There was a problem hiding this comment.
LGTM assuming we don't have any other warnings/from existing warnings/errors from the static analysis.
digitalinfinity
approved these changes
Feb 14, 2018
Author
|
@mhdawson Prefast is clean but there are regular compiler warnings relating to lossy implicit conversions to double. Only affects the unit test code, not the main source code itself. |
mhdawson
pushed a commit
that referenced
this pull request
Mar 1, 2018
Enabled VC++ static analysis PR-URL: #228 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
Member
|
Landed as faf19c4 |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Enabled VC++ static analysis PR-URL: nodejs/node-addon-api#228 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Enabled VC++ static analysis PR-URL: nodejs/node-addon-api#228 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Enabled VC++ static analysis PR-URL: nodejs/node-addon-api#228 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Enabled VC++ static analysis PR-URL: nodejs/node-addon-api#228 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #224.
The Napi::Error constructor was initializing the
std::string _messageprivate member variable tonullptr. As a class, std::string automatically initializes to the equivalent of a blank string._messageisn't a pointer; assigning a pointer literal (nullptr) to it causes static analysis warnings.I've also enabled Visual C++ Static Analysis (Prefast) in the test suite to detect these sorts of problems. If that isn't desirable let me know and I'll back out that part of the PR.