Skip to content

test: Add test for ThreadSafeFunction::New overloads#1251

Closed
JckXia wants to merge 3 commits intonodejs:mainfrom
JckXia:add-test-for-threadsafe-overloads
Closed

test: Add test for ThreadSafeFunction::New overloads#1251
JckXia wants to merge 3 commits intonodejs:mainfrom
JckXia:add-test-for-threadsafe-overloads

Conversation

@JckXia
Copy link
Copy Markdown
Member

@JckXia JckXia commented Dec 16, 2022

Add test coverage for ThreadSafeFunction New overloads

@JckXia JckXia added the test label Dec 16, 2022
Copy link
Copy Markdown
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson pushed a commit that referenced this pull request Jan 27, 2023
PR-URL: #1251
Reviewed-By: Michael Dawson <midawson@redhat.com
@mhdawson
Copy link
Copy Markdown
Member

Landed as a70564c

@mhdawson mhdawson closed this Jan 27, 2023
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
PR-URL: nodejs/node-addon-api#1251
Reviewed-By: Michael Dawson <midawson@redhat.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants