Fix crash due to ObjectWrap copying CallbackInfo#125
Closed
davedoesdev wants to merge 2 commits intonodejs:masterfrom
davedoesdev:fix-objectwrap-crash
Closed
Fix crash due to ObjectWrap copying CallbackInfo#125davedoesdev wants to merge 2 commits intonodejs:masterfrom davedoesdev:fix-objectwrap-crash
davedoesdev wants to merge 2 commits intonodejs:masterfrom
davedoesdev:fix-objectwrap-crash
Conversation
addaleax
approved these changes
Sep 2, 2017
Member
addaleax
left a comment
There was a problem hiding this comment.
In the tests the code style is a bit off ({ on the previous line, 2-space indentation), but other than that this looks good.
Thank you!
Contributor
Author
|
I'm happy to reformat. Can you recommend a utility to help? |
Contributor
Author
|
Reformatted by hand. |
Member
I don’t think we have any tooling, but we should probably look into copying Node core’s C++ linter to this repo |
mhdawson
pushed a commit
that referenced
this pull request
Sep 20, 2017
PR-URL: #125 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Member
|
Landed as ec33379 |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
PR-URL: nodejs/node-addon-api#125 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
PR-URL: nodejs/node-addon-api#125 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
PR-URL: nodejs/node-addon-api#125 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
PR-URL: nodejs/node-addon-api#125 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ObjectWrapconstructor takesCallbackInfoby value so_dynamicArgsgets released twice. Occurs with >6 args to theObjectWrapconstructor.