test: removed the usage of default_configuration.#1226
Closed
NickNaso wants to merge 5 commits intonodejs:mainfrom
Closed
test: removed the usage of default_configuration.#1226NickNaso wants to merge 5 commits intonodejs:mainfrom
NickNaso wants to merge 5 commits intonodejs:mainfrom
Conversation
legendecas
reviewed
Nov 4, 2022
mhdawson
reviewed
Nov 25, 2022
| if (await checkBuildType(buildTypes.Debug)) { | ||
| buildType = buildTypes.Debug; | ||
| let buildType; | ||
| const envBuildType = process.env.BUILD_TYPE; |
Member
There was a problem hiding this comment.
Suggested change
| const envBuildType = process.env.BUILD_TYPE; | |
| const envBuildType = process.env.BUILD_TYPE || 'Release'; |
Member
There was a problem hiding this comment.
Suggestion in meeting from @vmoroz how about process.env.NODE_API_BUILD_CONFIG
legendecas
approved these changes
Dec 2, 2022
mhdawson
pushed a commit
that referenced
this pull request
Dec 2, 2022
PR-URL: #1226 Reviewed-By: Michael Dawson <midawson@redhat.com Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Member
|
Landed as 10ad762 |
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
PR-URL: nodejs/node-addon-api#1226 Reviewed-By: Michael Dawson <midawson@redhat.com Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR remove the usage of
process.config.target_defaults.default_configurationin all test suite.A new function
whichBuildTypehas been introduced and it has the reponsability to check which type of buildnode-gypmade so the test can refer to the right folders.Refs: