Closed
Conversation
Signed-off-by: Michael Dawson <mdawson@devrus.com>
Member
Author
|
Fix a couple of the files, starting alphabetically + clang-format since I need to tweak on my machine and it triggers linter errors. |
Member
Author
|
Looks like all the failures are an issue related to github not having 16.04 machines. @NickNaso wondering if you could review so I can land. |
mhdawson
added a commit
that referenced
this pull request
Sep 28, 2021
Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #1077 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Member
Author
|
Landed as 4351bff |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs/node-addon-api#1077 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs/node-addon-api#1077 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs/node-addon-api#1077 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs/node-addon-api#1077 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Dawson mdawson@devrus.com