src,test: allow creating Function with move-only functor#1065
Merged
NickNaso merged 1 commit intonodejs:mainfrom Sep 17, 2021
Merged
src,test: allow creating Function with move-only functor#1065NickNaso merged 1 commit intonodejs:mainfrom
NickNaso merged 1 commit intonodejs:mainfrom
Conversation
Function::New fails to compile when given a move-only functor. For example, when constructing a callback function for Promise#then, a lambda might capture an ObjectReference. Creating a Function for such a lambda results in a compilation error. Tweak Function::New to work with move-only functors. For existing users of Function::New, this commit should not change behavior.
mhdawson
approved these changes
Sep 8, 2021
Member
mhdawson
left a comment
There was a problem hiding this comment.
LGTM. I think this looks ok. @gabrielschulhof do you see any concerns?
gabrielschulhof
approved these changes
Sep 10, 2021
Member
Member
|
@NickNaso I think you were going to land this if I remember correctly? |
Member
Yes, I will do it later, today. After the merge I will need to make a new release |
Member
Yes since this added functionality I marked it as SemVer minor and we should bump the minor part in the next release. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Function::New fails to compile when given a move-only functor. For
example, when constructing a callback function for Promise#then, a
lambda might capture an ObjectReference. Creating a Function for such a
lambda results in a compilation error.
Tweak Function::New to work with move-only functors.
For existing users of Function::New, this commit should not change
behavior.