src: fix leak in AsyncProgressWorkerBase<DataType>

fholzer · mhdawson · commit ceb27d49498c · 2020-09-22T14:19:37.000-04:00
Fix leak of ThreadSafeData in AsyncProgressWorkerBase<DataType> PR-URL: #795 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
diff --git a/napi-inl.h b/napi-inl.h
@@ -4730,6 +4730,7 @@ inline void AsyncProgressWorkerBase<DataType>::OnAsyncWorkProgress(Napi::Env /*
                                 void* data) {
   ThreadSafeData* tsd = static_cast<ThreadSafeData*>(data);
   tsd->asyncprogressworker()->OnWorkProgress(tsd->data());
+  delete tsd;
 }
 
 template <typename DataType>

Original file line number	Diff line number	Diff line change
`@@ -4730,6 +4730,7 @@ inline void AsyncProgressWorkerBase<DataType>::OnAsyncWorkProgress(Napi::Env /*`
`4730`	`4730`	`void* data) {`
`4731`	`4731`	`ThreadSafeData* tsd = static_cast<ThreadSafeData*>(data);`
`4732`	`4732`	`tsd->asyncprogressworker()->OnWorkProgress(tsd->data());`
	`4733`	`+ delete tsd;`
`4733`	`4734`	`}`
`4734`	`4735`
`4735`	`4736`	`template <typename DataType>`