stream: normalize fused stateless transform results - #65367
Open
trivikr wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
Normalize each stateless transform result before passing it to the next transform in a fused run. This ensures that subsequent transforms always receive Uint8Array[] batches in both synchronous and asynchronous pipelines. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol
trivikr
force-pushed
the
stream-iter-stateless-transform-intermediate-output
branch
from
August 18, 2026 03:01
f42db5e to
a780551
Compare
jasnell
approved these changes
Aug 18, 2026
This comment was marked as resolved.
This comment was marked as resolved.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65367 +/- ##
==========================================
- Coverage 90.15% 90.11% -0.04%
==========================================
Files 752 752
Lines 251884 251907 +23
Branches 47368 47373 +5
==========================================
- Hits 227078 227009 -69
- Misses 16164 16236 +72
- Partials 8642 8662 +20
🚀 New features to boost your workflow:
|
Collaborator
| if (isUint8Array(result)) return [result]; | ||
| if (typeof result === 'string') return [toUint8Array(result)]; | ||
| if (isAnyArrayBuffer(result)) return [new Uint8Array(result)]; | ||
| if (ArrayBufferIsView(result)) return [arrayBufferViewToUint8Array(result)]; |
Contributor
There was a problem hiding this comment.
Question: shouldn't we return result as default if none of the if cases match ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #65366
Normalize each stateless transform result before passing it to the next transform in a fused run. This ensures that subsequent transforms always receive Uint8Array[] batches in both synchronous and asynchronous pipelines.
Assisted-by: codex:gpt-5.6-sol