doc,src,test: fix dead inspector help URL by semimikoh · Pull Request #62745 · nodejs/node

semimikoh · 2026-04-14T23:12:55Z

The inspector help message pointed to https://nodejs.org/en/docs/inspector
which returns a 404. Updated to https://nodejs.org/api/inspector.html.

src: update URL in inspector_socket_server.cc
doc: update example output in inspector.md and debugger.md
test: update response pattern in test-inspector-help-page.js

Fixes: #62743

nodejs-github-bot · 2026-04-14T23:13:00Z

Review requested:

@nodejs/inspector

codecov · 2026-04-15T00:53:24Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.69%. Comparing base (d080801) to head (4df9c8a).
⚠️ Report is 60 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #62745      +/-   ##
==========================================
- Coverage   91.55%   89.69%   -1.86%     
==========================================
  Files         355      706     +351     
  Lines      149381   218127   +68746     
  Branches    23364    41733   +18369     
==========================================
+ Hits       136765   195650   +58885     
- Misses      12354    14395    +2041     
- Partials      262     8082    +7820

Files with missing lines	Coverage Δ
src/inspector_socket_server.cc	`84.23% <100.00%> (ø)`

... and 471 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mertcanaltin

LGTM! Thanks for the edits!

legendecas · 2026-04-15T13:46:50Z

@@ -16,7 +16,7 @@ script to debug.
 ```console
 $ node inspect myscript.js
 < Debugger listening on ws://127.0.0.1:9229/621111f9-ffcb-4e82-b718-48a145fa5db8
-< For help, see: https://nodejs.org/en/docs/inspector
+< For help, see: https://nodejs.org/api/inspector.html


The page is actually moved to https://nodejs.org/learn/getting-started/debugging.

Suggested change

< For help, see: https://nodejs.org/api/inspector.html

< For help, see: https://nodejs.org/learn/getting-started/debugging

legendecas · 2026-04-15T13:47:13Z

@@ -28,7 +28,7 @@ function check(url, cb) {
    });

    res.on('end', common.mustCall(() => {
-      assert.match(result, />Debugging Node\.js</);
+      assert.match(result, /<title>Inspector \| Node\.js/);


The page https://nodejs.org/learn/getting-started/debugging still match this matcher.

legendecas · 2026-04-15T19:05:06Z

would you mind fixing the linter errors?

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

semimikoh · 2026-04-15T23:19:10Z

@legendecas Fixed the format-cpp linter error.

nodejs-github-bot · 2026-04-16T17:32:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72724/

nodejs-github-bot · 2026-04-18T15:17:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72760/

nodejs-github-bot · 2026-04-18T17:13:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72765/

semimikoh · 2026-04-20T00:05:34Z

@mertcanaltin @legendecas @lpinca The latest CI failures look unrelated to this change, since this PR only updates the inspector help
URL, docs, and the matching test expectation. Could CI be rerun when convenient?

nodejs-github-bot · 2026-04-20T14:03:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72798/

nodejs-github-bot · 2026-04-20T17:17:18Z

Commit Queue failed

- Loading data for nodejs/node/pull/62745 ✔ Done loading data for nodejs/node/pull/62745 ----------------------------------- PR info ------------------------------------ Title doc,src,test: fix dead inspector help URL (#62745) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch semimikoh:fix/inspector-dead-help-link -> nodejs:main Labels c++, inspector, author ready, needs-ci Commits 3 - doc,src,test: fix dead inspector help URL - doc,src,test: use moved inspector help page - src: fix clang-format style in inspector_socket_server Committers 1 - semimikoh <ejffjeosms@gmail.com> PR-URL: https://github.com/nodejs/node/pull/62745 Fixes: https://github.com/nodejs/node/issues/62743 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/62745 Fixes: https://github.com/nodejs/node/issues/62743 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 14 Apr 2026 23:12:55 GMT ✔ Approvals: 2 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/62745#pullrequestreview-4123045454 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/62745#pullrequestreview-4116488920 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-04-20T14:03:41Z: https://ci.nodejs.org/job/node-test-pull-request/72798/ - Querying data for job/node-test-pull-request/72798/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 62745 From https://github.com/nodejs/node * branch refs/pull/62745/merge -> FETCH_HEAD ✔ Fetched commits as 75606703e8e2..4df9c8a9c838 -------------------------------------------------------------------------------- Auto-merging doc/api/debugger.md [main 880b9be70a] doc,src,test: fix dead inspector help URL Author: semimikoh <ejffjeosms@gmail.com> Date: Wed Apr 15 08:11:47 2026 +0900 4 files changed, 9 insertions(+), 10 deletions(-) Auto-merging doc/api/debugger.md [main 0c9e2d3435] doc,src,test: use moved inspector help page Author: semimikoh <ejffjeosms@gmail.com> Date: Thu Apr 16 00:21:27 2026 +0900 4 files changed, 10 insertions(+), 9 deletions(-) [main d67ef2d2fb] src: fix clang-format style in inspector_socket_server Author: semimikoh <ejffjeosms@gmail.com> Date: Thu Apr 16 08:07:39 2026 +0900 1 file changed, 2 insertions(+), 1 deletion(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. (node:347) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated. (Use `node --trace-deprecation ...` to show where the warning was created) Rebasing (2/6) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- doc,src,test: fix dead inspector help URL

PR-URL: #62745
Fixes: #62743
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

[detached HEAD 07c6204944] doc,src,test: fix dead inspector help URL
Author: semimikoh <ejffjeosms@gmail.com>
Date: Wed Apr 15 08:11:47 2026 +0900
4 files changed, 9 insertions(+), 10 deletions(-)
Rebasing (3/6)
Rebasing (4/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc,src,test: use moved inspector help page

PR-URL: #62745
Fixes: #62743
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

[detached HEAD d5a7afe755] doc,src,test: use moved inspector help page
Author: semimikoh <ejffjeosms@gmail.com>
Date: Thu Apr 16 00:21:27 2026 +0900
4 files changed, 10 insertions(+), 9 deletions(-)
Rebasing (5/6)
Rebasing (6/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
src: fix clang-format style in inspector_socket_server

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
PR-URL: #62745
Fixes: #62743
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

[detached HEAD 50c3e79e00] src: fix clang-format style in inspector_socket_server
Author: semimikoh <ejffjeosms@gmail.com>
Date: Thu Apr 16 08:07:39 2026 +0900
1 file changed, 2 insertions(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/24680062576

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. labels Apr 14, 2026

doc,src,test: fix dead inspector help URL

2a6b732

semimikoh force-pushed the fix/inspector-dead-help-link branch from f955be0 to 2a6b732 Compare April 14, 2026 23:28

mertcanaltin approved these changes Apr 15, 2026

View reviewed changes

legendecas reviewed Apr 15, 2026

View reviewed changes

legendecas requested changes Apr 15, 2026

View reviewed changes

legendecas mentioned this pull request Apr 15, 2026

src: fix dead inspector help URL #62746

Closed

semimikoh force-pushed the fix/inspector-dead-help-link branch from 2a6b732 to 39d8662 Compare April 15, 2026 15:16

doc,src,test: use moved inspector help page

403ae9c

semimikoh force-pushed the fix/inspector-dead-help-link branch from 39d8662 to 403ae9c Compare April 15, 2026 15:24

legendecas approved these changes Apr 15, 2026

View reviewed changes

lpinca approved these changes Apr 15, 2026

View reviewed changes

src: fix clang-format style in inspector_socket_server

4df9c8a

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

legendecas approved these changes Apr 16, 2026

View reviewed changes

legendecas added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 16, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 16, 2026

lpinca mentioned this pull request Apr 18, 2026

src: fix dead inspector help URL #62802

Closed

1 task

bjohansebas approved these changes Apr 20, 2026

View reviewed changes

lpinca mentioned this pull request Apr 20, 2026

inspector: fix dead 'For help' URL printed by --inspect #62855

Open

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 20, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 20, 2026

	< For help, see: https://nodejs.org/api/inspector.html
	< For help, see: https://nodejs.org/learn/getting-started/debugging

Uh oh!

Conversation

semimikoh commented Apr 14, 2026

Uh oh!

nodejs-github-bot commented Apr 14, 2026

Uh oh!

codecov bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mertcanaltin left a comment

Choose a reason for hiding this comment

Uh oh!

legendecas Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

legendecas Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

legendecas commented Apr 15, 2026

Uh oh!

semimikoh commented Apr 15, 2026

Uh oh!

nodejs-github-bot commented Apr 16, 2026

Uh oh!

nodejs-github-bot commented Apr 18, 2026

Uh oh!

nodejs-github-bot commented Apr 18, 2026

Uh oh!

semimikoh commented Apr 20, 2026

Uh oh!

nodejs-github-bot commented Apr 20, 2026

Uh oh!

nodejs-github-bot commented Apr 20, 2026

PR-URL: #62745 Fixes: #62743 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #62745 Fixes: #62743 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> PR-URL: #62745 Fixes: #62743 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

[detached HEAD 50c3e79e00] src: fix clang-format style in inspector_socket_server Author: semimikoh <ejffjeosms@gmail.com> Date: Thu Apr 16 08:07:39 2026 +0900 1 file changed, 2 insertions(+), 1 deletion(-) Successfully rebased and updated refs/heads/main.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Apr 15, 2026 •

edited

Loading

PR-URL: #62745
Fixes: #62743
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #62745
Fixes: #62743
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
PR-URL: #62745
Fixes: #62743
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

[detached HEAD 50c3e79e00] src: fix clang-format style in inspector_socket_server
Author: semimikoh <ejffjeosms@gmail.com>
Date: Thu Apr 16 08:07:39 2026 +0900
1 file changed, 2 insertions(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.