repl: use vm DONT_CONTEXTIFY context#62371
Open
legendecas wants to merge 1 commit intonodejs:mainfrom
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62371 +/- ##
==========================================
- Coverage 91.60% 89.70% -1.90%
==========================================
Files 337 676 +339
Lines 140745 206693 +65948
Branches 21802 39582 +17780
==========================================
+ Hits 128925 185421 +56496
- Misses 11595 13424 +1829
- Partials 225 7848 +7623
🚀 New features to boost your workflow:
|
Member
|
For any usage case involving spinning up multiple concurrent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REPL does not need interception behavior in the vm context. Creating
a
DONT_CONTEXTIFYcontext to reduce the chance to be impacted by V8interceptor API changes.
No observable behavior or tests should break. This does not fix the
behavior in
vmwith the V8 upgrade, only REPL is fixed.Refs: #61898 (comment)