Skip to content

module: correctly detect top-level await in ambiguous contexts #58646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 8 commits into from
Aug 15, 2025
+94 −0
Merged

module: correctly detect top-level await in ambiguous contexts #58646

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5d805a1
module: correctly detect top-level await in ambiguous contexts
islandryu Jun 9, 2025
a8a3a33
use std::array
islandryu Jun 10, 2025
9d6a322
move test
islandryu Jun 16, 2025
c4f371b
fix format
islandryu Jun 22, 2025
2b3000c
add test for unrelated error
islandryu Jun 29, 2025
a60b3e0
undo a test that has been erased
islandryu Jun 29, 2025
e65cc6c
fix lint
islandryu Jun 29, 2025
993bcfc
Update test/es-module/test-esm-tla-syntax-errors-not-recognized-as-tl…
islandryu Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
undo a test that has been erased
  • Loading branch information
@islandryu
islandryu committed Jun 29, 2025
commit a60b3e04e120ffb71e02c78a7fe47daa748db203
21 changes: 21 additions & 0 deletions test/es-module/test-esm-detect-ambiguous.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,3 +426,24 @@ describe('when working with Worker threads', () => {
strictEqual(signal, null);
});
});

describe('cjs & esm ambiguous syntax case', () => {
it('should throw an ambiguous syntax error when using top-level await with require', async () => {
const { stderr, code, signal } = await spawnPromisified(
process.execPath,
[
'--input-type=module',
'--eval',
`await 1;\nconst fs = require('fs');`,
]
);

match(
stderr,
/ReferenceError: Cannot determine intended module format because both require\(\) and top-level await are present\. If the code is intended to be CommonJS, wrap await in an async function\. If the code is intended to be an ES module, replace require\(\) with import\./
);

strictEqual(code, 1);
strictEqual(signal, null);
});
});
Loading