Skip to content

build: harmonize Clang checks and update V8 warning cflags #52873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 2 commits into from
Closed

build: harmonize Clang checks and update V8 warning cflags #52873

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
791b8ff
build: harmonize Clang checks
targos May 7, 2024
3c2feaa
build: sync V8 warning cflags with BUILD.gn
targos May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
build: sync V8 warning cflags with BUILD.gn
  • Loading branch information
@targos
targos committed May 7, 2024
commit 3c2feaac907962ccc7242486329f549f5ba7bf63
1 change: 0 additions & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
'configuring_node%': 0,
'asan%': 0,
'ubsan%': 0,
'werror': '', # Turn off -Werror in V8 build.
'visibility%': 'hidden', # V8's visibility setting
'target_arch%': 'ia32', # set v8's target architecture
'host_arch%': 'ia32', # set v8's host architecture
Expand Down
28 changes: 18 additions & 10 deletions tools/v8_gypfiles/toolchain.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@
'v8_toolset_for_shell%': 'target',

'host_os%': '<(OS)',
'werror%': '-Werror',
# For a shared library build, results in "libv8-<(soname_version).so".
'soname_version%': '',

Expand Down Expand Up @@ -133,21 +132,33 @@
'<(V8_ROOT)',
'<(V8_ROOT)/include',
],
'cflags!': ['-Wall', '-Wextra'],
'conditions': [
['clang==1', {
'cflags': [ '-Werror', '-Wno-unknown-pragmas' ],
},{
'cflags!': [ '-Wall', '-Wextra' ],
['clang==0 and OS!="win"', {
'cflags': [
# In deps/v8/BUILD.gn: if (!is_clang && !is_win) { cflags += [...] }
'-Wno-strict-overflow',
'-Wno-return-type',
'-Wno-int-in-bool-context',
'-Wno-deprecated',
'-Wno-stringop-overflow',
'-Wno-stringop-overread',
'-Wno-restrict',
'-Wno-array-bounds',
'-Wno-nonnull',
'-Wno-dangling-pointer',
# On by default in Clang and V8 requires it at least for arm64.
'-flax-vector-conversions',
],
}],
['clang==1 or OS!="win"', {
'cflags': [ '-Wno-invalid-offsetof' ],
'cflags_cc': [
# In deps/v8/BUILD.gn: if (is_clang || !is_win) { cflags += [...] }
'-Wno-invalid-offsetof',
],
'xcode_settings': {
'WARNING_CFLAGS': ['-Wno-invalid-offsetof']
# -Wno-invalid-offsetof
'GCC_WARN_ABOUT_INVALID_OFFSETOF_MACRO': 'NO',
},
}],
['v8_target_arch=="arm"', {
Expand Down Expand Up @@ -434,9 +445,6 @@
['_toolset=="target"', {
'conditions': [
['v8_target_arch==target_arch', {
'cflags': [
'-Wno-error=array-bounds', # Workaround https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56273
],
'conditions': [
['v8_target_arch=="mips64el"', {
'cflags': ['-EL'],
Expand Down
6 changes: 0 additions & 6 deletions tools/v8_gypfiles/v8.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2132,12 +2132,6 @@
]
}],
],
# -Wno-invalid-offsetof flag is not valid for C.
# The flag is initially set in `toolchain.gypi` for all targets.
'cflags!': [ '-Wno-invalid-offsetof' ],
'xcode_settings': {
'WARNING_CFLAGS!': ['-Wno-invalid-offsetof']
},
'direct_dependent_settings': {
'include_dirs': [
'<(V8_ROOT)/third_party/zlib',
Expand Down