Skip to content

stream: don't emit finish on error #28979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 7 commits into from
Closed

stream: don't emit finish on error #28979

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1d9c349
stream: don't emit finish on error
ronag Aug 5, 2019
2ab2399
fixup
ronag Aug 23, 2019
102b232
fixup: check errorEmitted
ronag Aug 24, 2019
43b1537
fixup
ronag Aug 24, 2019
c4a2047
fixup
ronag Aug 30, 2019
62d16ec
fixup: docs
ronag Sep 11, 2019
7b33a42
Apply suggestions from code review
ronag Sep 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review 
Co-Authored-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
@ronag @Trott
ronag and Trott authored Sep 12, 2019
commit 7b33a42de48db62879ad7c95c9860d6ea9bc89a2
4 changes: 2 additions & 2 deletions doc/api/stream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2413,8 +2413,8 @@ and `stream.Readable` classes, respectively. The `'finish'` event is emitted
after [`stream.end()`][stream-end] is called and all chunks have been processed
by [`stream._transform()`][stream-_transform]. The `'end'` event is emitted
after all data has been output, which occurs after the callback in
[`transform._flush()`][stream-_flush] has been called. In the case of an error
neither `'finish'` nor `'end'` *should* be emitted.
[`transform._flush()`][stream-_flush] has been called. In the case of an error,
neither `'finish'` nor `'end'` should be emitted.

#### transform.\_flush(callback)

Expand Down