Skip to content

process: add --pending-deprecation to process.binding() #26500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 3 commits into from
Closed

process: add --pending-deprecation to process.binding() #26500

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5be6de9
process: add --pending-deprecation to `process.binding()`
addaleax Feb 25, 2019
eefd0c2
fixup! process: add --pending-deprecation to `process.binding()`
addaleax Mar 7, 2019
99109cd
fixup! process: add --pending-deprecation to `process.binding()`
addaleax Mar 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/api/deprecations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2136,7 +2136,7 @@ changes:
description: Documentation-only deprecation.
-->

Type: Documentation-only
Type: Documentation-only (supports [`--pending-deprecation`][])
Comment thread
addaleax marked this conversation as resolved.

`process.binding()` is for use by Node.js internal code only.

Expand Down
6 changes: 6 additions & 0 deletions lib/internal/bootstrap/pre_execution.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,12 @@ function initializeDeprecations() {
value: noBrowserGlobals
});
}

if (pendingDeprecation) {
process.binding = deprecate(process.binding,
'`process.binding()` is deprecated. ' +
Comment thread
addaleax marked this conversation as resolved.
Outdated
'Please use public APIs instead.', 'DEP0111');
}
}

function setupChildProcessIpcChannel() {
Expand Down
15 changes: 9 additions & 6 deletions test/parallel/test-err-name-deprecation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,14 @@ const common = require('../common');

// Flags: --pending-deprecation

common.expectWarning(
'DeprecationWarning',
'Directly calling process.binding(\'uv\').errname(<val>) is being ' +
'deprecated. Please make sure to use util.getSystemErrorName() instead.',
'DEP0119'
);
common.expectWarning({
DeprecationWarning: [
['`process.binding()` is deprecated. Please use public APIs instead.',
'DEP0111'],
['Directly calling process.binding(\'uv\').errname(<val>) is being ' +
'deprecated. Please make sure to use util.getSystemErrorName() instead.',
'DEP0119']
]
});

process.binding('uv').errname(-1);