Skip to content

Fix debug build on windows #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnhaley81 merged 1 commit into from
Feb 24, 2016
+1 −1
Merged

Fix debug build on windows #918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion generate/templates/templates/nodegit.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// This is a generated file, modify: generate/templates/nodegit.cc.

@joshaber joshaber Feb 24, 2016

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:trollface:?

@johnhaley81 johnhaley81 Feb 24, 2016

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's there in case somebody is looking at the generated file src/nodegit.cc and is like "why can't I commit my changes.

@tbranyen tbranyen Feb 25, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a Combyne comment above it?

{%-- JavaScript comment below alerts contributors to not edit the generated source --%}

@maxkorp maxkorp Feb 25, 2016

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably. That would at least clarify a bit. Might be nicer though if we just do that when we get the compiled output back, like
// This is a generated file, modify: {root template}. in the generateNativeCode.js

Looks like it's around lines 117/120 (probably a few others too)

#include <node.h>
#include <v8.h>

#include <node.h>
#include <git2.h>
#include <map>
#include <algorithm>
Expand Down