Skip to content

Don't check for \\ No newline at end of file\n if it can't exist #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
implausible merged 1 commit into from
Feb 18, 2016
Merged

Don't check for \\ No newline at end of file\n if it can't exist #908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions generate/templates/manual/src/convenient_patch.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,17 @@ PatchData *createFromRaw(git_patch *raw) {
const git_diff_line *line;
git_patch_get_line_in_hunk(&line, raw, i, j);

if (
j == 0 &&
!strcmp(
&line->content[strlen(line->content) - 29],
"\n\\ No newline at end of file\n"
)) {
EOFFlag = true;
if (j == 0) {
// calculate strlen only once for the first line of the first hunk.
int calculatedContentLength = strlen(line->content);
if (
calculatedContentLength > 29 &&
!strcmp(
&line->content[calculatedContentLength - 29],
"\n\\ No newline at end of file\n"
)) {
EOFFlag = true;
}
}

storeLine->origin = line->origin;
Expand Down