Update to 0.4.0 - #548
Conversation
8c2b825 to
16c91ba
Compare
|
Boom! I'm ready to publish 0.4.0, when ya'll are. |
|
Do we want to get https://github.com/nodegit/nodegit/tree/blobToBuffer in? |
|
That'd be cool, I'm not in any particular rush, especially since the next steps are publishing... |
|
All that needs now is a solid test. But it's working. |
caf37af to
3fcbbe4
Compare
|
What's the status of this 0.4.0 release? |
|
@bleathem will probably happen tomorrow hopefully |
|
👍 you guys rock! |
Also made it easier to update third party packages based on current NODE_VERSION.
|
For some reason Linux w/ Node 0.12 is the only one failing. No idea why, but we need this figured out before publishing. |
Some things that override node's `require` (e.g. jest) might break when including nodegit since. This is a workaround until they fix that. I made an issue at jestjs/jest#353
nan ^1.8.0 breaks electron :(
|
@johnhaley81 nan isn't the issue as far as I can tell. I noticed the same errors with or without it. As you can see by the previous builds, the latest version of nan works just fine in everything except for Node 0.12 in Linux. |
|
Nan 1.8.x was doing some weird stuff with electron for sure but it does seem to fix it for CI. Something weird is going on. I did remember people on the nan repo saying that 1.8 is not backwards compatible. Are you able to build it locally with 1.8? |
|
No I wasn't able to build with 1.7 or 1.8. Although like you said CI appears to be fixed. |
|
I'll update the changelog again in a commit straight to master so that it gets updated to v0.4.0 |
Updated all third-party dependencies as well.