Fix atom-shell build on windows - #512
Merged
Merged
Conversation
johnhaley81
force-pushed
the
fix-atom-shell-windows-compiler-error
branch
2 times, most recently
from
March 24, 2015 20:05
e9bbe02 to
e2e67c9
Compare
When compiling against the latest (0.22.1 currently) atom-shell something was defining `HAVE_POLL` which is a linux system header file. This was breaking the atom-shell build on windows.
johnhaley81
force-pushed
the
fix-atom-shell-windows-compiler-error
branch
from
March 24, 2015 20:34
e2e67c9 to
2c0b94e
Compare
johnhaley81
added a commit
that referenced
this pull request
Mar 24, 2015
…error Fix atom-shell build on windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling against the latest (0.22.1 currently) atom-shell
something was defining
HAVE_POLLwhich is a linux system headerfile. This was breaking the atom-shell build on windows.