Fix test issues - #388
Merged
Merged
Conversation
Collaborator
|
Nope :( Any other ideas? |
maxkorp
force-pushed
the
fix-windows-tests
branch
3 times, most recently
from
February 6, 2015 19:56
6fa028a to
9eae810
Compare
maxkorp
force-pushed
the
fix-windows-tests
branch
from
February 9, 2015 20:28
9eae810 to
4e9d709
Compare
maxkorp
force-pushed
the
fix-windows-tests
branch
from
February 10, 2015 17:54
4e9d709 to
484f970
Compare
Collaborator
|
Are we good to merge this in? |
Collaborator
Author
|
Not quite, tidying up some messes i made first, and I want to rebase etc beforehand. Gimme 30 to an hour 👍 |
Collaborator
|
Great job on this btw. I hope this clears up our windows test issues :) |
maxkorp
force-pushed
the
fix-windows-tests
branch
from
February 10, 2015 19:11
dad4b8a to
60d41bb
Compare
Collaborator
Author
|
I'm hoping so. I was able to repro both issues in windows (clone not quite as consistantly, but fairly regularly) and they're both working locally now (and still work in osx), so I'm hopeful. The big takeaway here is to listen to node-gyp's warnings about uninitialized vars, that's what was biting us with the status tests. What weirds me out is that the status tests were passing for me locally before... |
Collaborator
Author
|
Huzzah! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some slashes getting through to exec in the test runner which I suspect is behind #316.
This fixes those, and a few other things.