Skip to content

fix signature.now and add signature tests #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxkorp merged 1 commit into from
Dec 1, 2014
Merged

fix signature.now and add signature tests #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion generate/input/descriptor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1158,7 +1158,10 @@
"functions": {
"git_signature_new": {
"isAsync": false
}
},
"git_signature_now": {
"isAsync": false
}
}
},
"smart": {
Expand Down
35 changes: 35 additions & 0 deletions test/tests/signature.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
var assert = require("assert");

describe("Signature", function() {

var Signature = require("../../lib/signature");
var name = "Bob Gnarley";
var email = "gnarlee@bob.net";
var arbitraryDate = 123456789;
var timezoneOffset = 60;

it("can be created at an arbitrary time", function() {
var create = Signature.create;
var signature = create(name, email, arbitraryDate, timezoneOffset);

assert.equal(signature.name(), name);
assert.equal(signature.email(), email);
assert.equal(signature.when().time(), arbitraryDate);
assert.equal(signature.when().offset(), 60);

});

it("can be created now", function() {

var signature = Signature.now(name, email);
var now = new Date();
var when = signature.when();
var diff = Math.abs(when.time() - now/1000);
assert.equal(signature.name(), name);
assert.equal(signature.email(), email);
assert(diff <= 1);

// libgit2 does its timezone offsets backwards from javascript
assert.equal(when.offset(), -now.getTimezoneOffset());
});
});