Update Readme, to improve example code - #248
Merged
Merged
Conversation
Refactored code to use promises chaining for more clarity and less callback hell.
Member
|
Ha, I was just thinking of doing this myself. Thanks! |
Member
There was a problem hiding this comment.
Looks like some extra space here.
Contributor
Author
There was a problem hiding this comment.
There were some lines already, I left extra spaces before every comment. That's just a style choice. You can make the call.
Member
There was a problem hiding this comment.
Nope, if you look at the diff the comment aligned with console. Now it's off by a few. Sorry if I wasn't clear.
Member
|
No worries, I'll fix the whitespace issue. Thanks for the contribution! |
tbranyen
added a commit
that referenced
this pull request
Oct 22, 2014
Update Readme, to improve example code
Contributor
Author
|
Sorry I missed that. — On Wed, Oct 22, 2014 at 8:50 PM, Tim Branyen notifications@github.com
|
Member
|
NP it was just a whitespace issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored code to use promises chaining for more clarity and less callback hell.