Skip to content

NodeJS v0.11.13 compatibility - #175

Merged
3y3 merged 1 commit into
nodegit:masterfrom
3y3:master
Jun 10, 2014
Merged

NodeJS v0.11.13 compatibility#175
3y3 merged 1 commit into
nodegit:masterfrom
3y3:master

Conversation

@3y3

@3y3 3y3 commented Jun 9, 2014

Copy link
Copy Markdown
Contributor

No description provided.

@3y3

3y3 commented Jun 9, 2014

Copy link
Copy Markdown
Contributor Author

I work on errors and I'll call, when this will be ready to review.

If someone has a time - help me, please.

@tbranyen

tbranyen commented Jun 9, 2014

Copy link
Copy Markdown
Member

Awesome, thanks for submitting this! I'll review and try and help, and recruit.

@tbranyen

tbranyen commented Jun 9, 2014

Copy link
Copy Markdown
Member

@3y3 can you limit the use of squash and force on this branch now that it's linked to a PR?

@3y3

3y3 commented Jun 9, 2014

Copy link
Copy Markdown
Contributor Author

ok, now I move my test to private branch. You are welcome.

@tbranyen

tbranyen commented Jun 9, 2014

Copy link
Copy Markdown
Member

Thanks! I was just getting confused when SHAs became inconsistent.

@3y3

3y3 commented Jun 10, 2014

Copy link
Copy Markdown
Contributor Author

@tbranyen , pr was builded and passed the tests. Error on 0.8.0 is not a problem of pr. Ready to review (or I can squash it previously)

@diorahman

Copy link
Copy Markdown

Whoa nice! Thanks for this.

@tbranyen

Copy link
Copy Markdown
Member

@3y3 if you fetch latest, rebase to master, and force push back up Travis won't test 0.8 and your PR will pass.

@3y3

3y3 commented Jun 10, 2014

Copy link
Copy Markdown
Contributor Author

@tbranyen , all ready.

@tbranyen

Copy link
Copy Markdown
Member

@3y3 added you to the organization, feel free to merge when you're ready. Hope to see more great work from ya!

@3y3

3y3 commented Jun 10, 2014

Copy link
Copy Markdown
Contributor Author

Thank you. I merge this and start to read Descriptor refactor.

3y3 added a commit that referenced this pull request Jun 10, 2014
NodeJS v0.11.13 compatibility
@3y3
3y3 merged commit c518174 into nodegit:master Jun 10, 2014
@3y3

3y3 commented Jun 10, 2014

Copy link
Copy Markdown
Contributor Author

Landed as c518174

3y3 added a commit that referenced this pull request Jun 10, 2014
NodeJS v0.11.13 compatibility
@3y3

3y3 commented Jun 10, 2014

Copy link
Copy Markdown
Contributor Author

@tbranyen , I'm really sorry - in three thousands of changed lines I missed one important unrelated change . Which strategy to clear this is preferred - new commit, new pr, or overriding?

@tbranyen

Copy link
Copy Markdown
Member

No big deal, I'm fighting with AppVeyor at the moment to get our Windows builds passing. I'd just hotfix directly to master.

@tbranyen

Copy link
Copy Markdown
Member

Also maybe you have perspective on #165 now :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants