Skip to content

Fix rebase using in-memory index - #1717

Merged
implausible merged 2 commits into
nodegit:masterfrom
henkesn:rebase-inmemory
Sep 6, 2019
Merged

Fix rebase using in-memory index#1717
implausible merged 2 commits into
nodegit:masterfrom
henkesn:rebase-inmemory

Conversation

@henkesn

@henkesn henkesn commented Aug 30, 2019

Copy link
Copy Markdown
Contributor

In the current master there is missing the RebaseOptions#inmemory flag. This is why rebasing is currently not possible at all on bare repos. This fix adds the missing field in supplements config file. Rebasing works fine with Rebase.init.

@implausible

Copy link
Copy Markdown
Member

Would you write a test case that utilizes the inmemory field?

@henkesn

henkesn commented Sep 6, 2019

Copy link
Copy Markdown
Contributor Author

Hm, the build process seems broken.

@implausible

implausible commented Sep 6, 2019

Copy link
Copy Markdown
Member

Yup. It looks like github actions aren't quite ready to handle the pull_request event right now. actions/checkout#23

@implausible
implausible merged commit f2fea6a into nodegit:master Sep 6, 2019
@henkesn

henkesn commented Sep 6, 2019

Copy link
Copy Markdown
Contributor Author

Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants